Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1022)

Issue 2654363002: ios: Fix constructor call (Closed)

Created:
3 years, 10 months ago by Nico
Modified:
3 years, 10 months ago
CC:
chromium-reviews, marq+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ios: Fix constructor call The expression was referring directly to the constructor, but it needs to refer to the type. New versions of Clang started erroring on this (see bug). BUG=684590 Review-Url: https://codereview.chromium.org/2654363002 Cr-Commit-Position: refs/heads/master@{#446397} Committed: https://chromium.googlesource.com/chromium/src/+/873a0b98cbf3a3e6aa5f2b0cc2f1138257fdf21b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M ios/chrome/browser/tabs/tab.mm View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Nico
3 years, 10 months ago (2017-01-26 18:45:51 UTC) #3
rohitrao (ping after 24h)
lgtm Out of curiosity, does the new code have a different effect than the old ...
3 years, 10 months ago (2017-01-26 18:47:47 UTC) #5
Nico
I think they used to do the same thing in practice.
3 years, 10 months ago (2017-01-26 18:54:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2654363002/1
3 years, 10 months ago (2017-01-26 18:58:22 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-01-26 19:40:00 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/873a0b98cbf3a3e6aa5f2b0cc2f1...

Powered by Google App Engine
This is Rietveld 408576698