Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2654313003: [Android] Fix a crash when clickable view ids is sent as null in CCT (Closed)

Created:
3 years, 11 months ago by Ian Wen
Modified:
3 years, 11 months ago
Reviewers:
Yusuf
CC:
chromium-reviews, lizeb+watch-custom-tabs_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Fix a crash when clickable view ids is sent as null in CCT We were calling clone() on a potentially null object, which caused crashes. BUG=645426 Review-Url: https://codereview.chromium.org/2654313003 Cr-Commit-Position: refs/heads/master@{#446446} Committed: https://chromium.googlesource.com/chromium/src/+/a90bb521817edb51ac6c5643d15dc175a6ef5adc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Ian Wen
PTAL
3 years, 11 months ago (2017-01-26 19:46:05 UTC) #2
Yusuf
lgtm
3 years, 11 months ago (2017-01-26 20:47:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2654313003/1
3 years, 11 months ago (2017-01-26 21:02:50 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-26 21:09:11 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a90bb521817edb51ac6c5643d15d...

Powered by Google App Engine
This is Rietveld 408576698