Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issue 2654263002: [stubs] Fix bug in ArrayPush builtin that only surfaces on MIPS debug (Closed)

Created:
3 years, 11 months ago by danno
Modified:
3 years, 11 months ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] Fix bug in ArrayPush builtin that only surfaces on MIPS debug The v8 waterfall currently doesn't run MIPS tests in the debug configuration, so although there are tests that would have found them, they currently are not running in the standard CI setup. A bug has been fixed to add the debug configuration of MIPS & MIPS64, too. Review-Url: https://codereview.chromium.org/2654263002 Cr-Commit-Position: refs/heads/master@{#42727} Committed: https://chromium.googlesource.com/v8/v8/+/fd918b595b66d6e26c99d508d8a84e7da2f044ce

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M src/builtins/builtins-array.cc View 2 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
danno
ptal
3 years, 11 months ago (2017-01-26 13:35:24 UTC) #3
Igor Sheludko
lgtm
3 years, 11 months ago (2017-01-27 07:52:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2654263002/1
3 years, 11 months ago (2017-01-27 08:14:09 UTC) #6
commit-bot: I haz the power
3 years, 11 months ago (2017-01-27 08:48:41 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/fd918b595b66d6e26c99d508d8a84e7da2f...

Powered by Google App Engine
This is Rietveld 408576698