Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2654253004: DevTools: fix flame chart on profiler pane (Closed)

Created:
3 years, 11 months ago by caseq
Modified:
3 years, 10 months ago
Reviewers:
alph
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: fix flame chart on profiler pane This also includes a stub for FlameChart smoke tests. BUG=685838 Review-Url: https://codereview.chromium.org/2654253004 Cr-Commit-Position: refs/heads/master@{#447612} Committed: https://chromium.googlesource.com/chromium/src/+/c84d488aa22e7c9a660b2c8f84a9a7edcc9a7e3f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/inspector/components/flame-chart.html View 1 chunk +97 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/components/flame-chart-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/perf_ui/FlameChart.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (8 generated)
caseq
3 years, 11 months ago (2017-01-26 23:32:44 UTC) #2
alph
lgtm
3 years, 11 months ago (2017-01-27 00:19:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2654253004/1
3 years, 11 months ago (2017-01-27 00:20:35 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/377157)
3 years, 11 months ago (2017-01-27 02:04:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2654253004/1
3 years, 10 months ago (2017-01-27 17:23:03 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/352180)
3 years, 10 months ago (2017-01-27 17:31:12 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2654253004/1
3 years, 10 months ago (2017-02-01 19:48:22 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-01 21:24:07 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c84d488aa22e7c9a660b2c8f84a9...

Powered by Google App Engine
This is Rietveld 408576698