Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 2654253002: [iwyu] Include handles.h less. (Closed)

Created:
3 years, 11 months ago by marja
Modified:
3 years, 10 months ago
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[iwyu] Include handles.h less. These headers only need forward declarations. BUG=v8:5294 Review-Url: https://codereview.chromium.org/2654253002 Cr-Commit-Position: refs/heads/master@{#42740} Committed: https://chromium.googlesource.com/v8/v8/+/92f36954bba844a069cb703178ba60a183cec13e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -20 lines) Patch
M src/accessors.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/api-experimental.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/builtins/builtins.h View 1 chunk +5 lines, -1 line 0 comments Download
M src/compilation-cache.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/conversions.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/conversions.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/execution.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/fast-accessor-assembler.h View 2 chunks +3 lines, -2 lines 0 comments Download
M src/field-type.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/futex-emulation.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/i18n.h View 2 chunks +3 lines, -1 line 0 comments Download
M src/interpreter/handler-table-builder.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/objects/scope-info.h View 2 chunks +4 lines, -1 line 0 comments Download
M src/parsing/func-name-inferrer.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/parsing/scanner-character-streams.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/regexp/jsregexp-inl.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/source-position-table.h View 2 chunks +2 lines, -1 line 0 comments Download
M test/cctest/heap/heap-tester.h View 2 chunks +3 lines, -1 line 0 comments Download
M test/common/wasm/wasm-module-runner.h View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 21 (13 generated)
marja
ptal
3 years, 11 months ago (2017-01-26 15:45:34 UTC) #8
Michael Starzinger
LGTM.
3 years, 11 months ago (2017-01-26 15:58:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2654253002/1
3 years, 10 months ago (2017-01-27 08:01:08 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/33505)
3 years, 10 months ago (2017-01-27 08:04:49 UTC) #13
marja
yangguo, ptal @ regexp
3 years, 10 months ago (2017-01-27 10:44:27 UTC) #15
Yang
src/regexp lgtm
3 years, 10 months ago (2017-01-27 12:38:02 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2654253002/1
3 years, 10 months ago (2017-01-27 12:38:41 UTC) #18
commit-bot: I haz the power
3 years, 10 months ago (2017-01-27 13:53:19 UTC) #21
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/92f36954bba844a069cb703178ba60a183c...

Powered by Google App Engine
This is Rietveld 408576698