Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Issue 2654243002: Remove trace frame template specialization. (Closed)

Created:
3 years, 11 months ago by sof
Modified:
3 years, 11 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, mlamouri+watch-blink_chromium.org, dcheng, dglazkov+blink, blink-reviews, kinuko+watch, blink-reviews-api_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove trace frame template specialization. More tidying after r445993, only one instantiation of these method templates. R=haraken BUG=683019 Review-Url: https://codereview.chromium.org/2654243002 Cr-Commit-Position: refs/heads/master@{#446302} Committed: https://chromium.googlesource.com/chromium/src/+/4bc8ee0bc2934699e0bed53f43f74166e1998185

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -43 lines) Patch
M third_party/WebKit/Source/web/OpenedFrameTracker.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/OpenedFrameTracker.cpp View 1 chunk +2 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/web/WebFrame.cpp View 3 chunks +3 lines, -23 lines 0 comments Download
M third_party/WebKit/public/web/WebFrame.h View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
sof
please take a look.
3 years, 11 months ago (2017-01-26 09:54:20 UTC) #4
haraken
LGTM
3 years, 11 months ago (2017-01-26 09:59:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2654243002/1
3 years, 11 months ago (2017-01-26 11:38:13 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-26 11:42:54 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4bc8ee0bc2934699e0bed53f43f7...

Powered by Google App Engine
This is Rietveld 408576698