chrome/android/java/res/layout/history_item_view.xml - Issue 2654193002: [Android History] List item shadows and width constrained styling

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/res/layout/history_item_view.xml

Issue 2654193002: [Android History] List item shadows and width constrained styling (Closed)

Patch Set: Changes from dgn@ and dfalcantara@ reviews Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/android/java/res/layout/history_item_view.xml

diff --git a/chrome/android/java/res/layout/history_item_view.xml b/chrome/android/java/res/layout/history_item_view.xml

index a38f855309c708d79998f2f2ab5f5ba73beb57d3..55533d891f6780108519faa9b85e7bb4e2b1a95e 100644

--- a/chrome/android/java/res/layout/history_item_view.xml

+++ b/chrome/android/java/res/layout/history_item_view.xml

@@ -15,8 +15,7 @@

android:layout_height="wrap_content"

android:paddingTop="16dp"

android:paddingBottom="16dp"

- android:orientation="horizontal"

- android:background="@android:color/white" >

+ android:orientation="horizontal" >

<ImageView

android:id="@+id/icon_view"

@@ -28,7 +27,8 @@

android:layout_width="0dp"

android:layout_height="wrap_content"

android:layout_weight="1"

- android:orientation="vertical" >

+ android:orientation="vertical"

+ android:paddingStart="16dp" >

<TextView

android:id="@+id/title"