chrome/android/java/res/layout/history_header.xml - Issue 2654193002: [Android History] List item shadows and width constrained styling

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/res/layout/history_header.xml

Issue 2654193002: [Android History] List item shadows and width constrained styling (Closed)

Patch Set: Changes from dgn@ and dfalcantara@ reviews Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/android/java/res/layout/history_header.xml

diff --git a/chrome/android/java/res/layout/history_header.xml b/chrome/android/java/res/layout/history_header.xml

index c57ef18a13f7dfd2ab233a460cd9a7ff710971c9..51b940e10fde9a63da14a7e84213e58869286dbc 100644

--- a/chrome/android/java/res/layout/history_header.xml

+++ b/chrome/android/java/res/layout/history_header.xml

@@ -6,7 +6,8 @@

<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"

android:layout_width="match_parent"

android:layout_height="wrap_content"

- android:orientation="vertical" >

+ android:orientation="vertical"

+ android:layout_marginBottom="8dp" >

<org.chromium.ui.widget.TextViewWithClickableSpans

android:id="@+id/signed_in_not_synced"

@@ -24,8 +25,7 @@

android:layout_width="match_parent"

android:layout_height="wrap_content"

android:layout_marginTop="16dp"

- android:layout_marginBottom="8dp"

- android:background="@android:color/white" >

+ android:background="@drawable/list_item_single" >

<Button

android:id="@+id/clear_browsing_data_button"