Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 2654143006: Tidy generated toMemberNativeArray<>() invocations. (Closed)

Created:
3 years, 10 months ago by sof
Modified:
3 years, 10 months ago
Reviewers:
haraken, bashi
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Tidy generated toMemberNativeArray<>() invocations. R=haraken BUG=682910 Review-Url: https://codereview.chromium.org/2654143006 Cr-Commit-Position: refs/heads/master@{#446662} Committed: https://chromium.googlesource.com/chromium/src/+/d485f3fa2f0063640ca4acdcad20ac1c13ee8115

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M third_party/WebKit/Source/bindings/scripts/v8_types.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionary.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp View 7 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestTypedefs.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
sof
please take a look. nit noticed in passing.
3 years, 10 months ago (2017-01-27 10:39:36 UTC) #4
haraken
LGTM
3 years, 10 months ago (2017-01-27 10:42:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2654143006/1
3 years, 10 months ago (2017-01-27 12:51:32 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-01-27 14:11:35 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d485f3fa2f0063640ca4acdcad20...

Powered by Google App Engine
This is Rietveld 408576698