Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Issue 2654143005: gn: fix fuzzer bug in parser for stack local (Closed)

Created:
3 years, 11 months ago by scottmg
Modified:
3 years, 10 months ago
Reviewers:
brettw
CC:
chromium-reviews, Dirk Pranke, tfarina, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gn: fix fuzzer bug in parser for stack local ParseNode::GetRange() returns a LocationRange by value, so the reference taken is invalid at the next ;. Copy the Location by value instead. R=brettw@chromium.org BUG=683454 Review-Url: https://codereview.chromium.org/2654143005 Cr-Commit-Position: refs/heads/master@{#446528} Committed: https://chromium.googlesource.com/chromium/src/+/0fcc08c5d93f2e8128d5e583c236dd2a81e70a7b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/gn/parser.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (10 generated)
scottmg
3 years, 11 months ago (2017-01-26 22:55:42 UTC) #3
scottmg
3 years, 11 months ago (2017-01-26 23:00:11 UTC) #7
brettw
lgtm
3 years, 11 months ago (2017-01-26 23:18:59 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2654143005/1
3 years, 10 months ago (2017-01-27 01:42:29 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-01-27 01:49:35 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0fcc08c5d93f2e8128d5e583c236...

Powered by Google App Engine
This is Rietveld 408576698