Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 2654133003: Allow vibrate in cross-origin iframes with user gesture. (Closed)

Created:
3 years, 11 months ago by Rick Byers
Modified:
3 years, 11 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Allow vibrate in cross-origin iframes with user gesture. This is to fix the issue of breaking some use cases of vibrate in cross-origin iframes. Once the iframe has ever received a user gesture, it will be allowed to call vibrate. See more context: https://github.com/WICG/interventions/issues/25 BUG=683938 Review-Url: https://codereview.chromium.org/2642263006 Cr-Commit-Position: refs/heads/master@{#445631} (cherry picked from commit 8f4a5209d0e6306060e901f89f345517e0df6219) Review-Url: https://codereview.chromium.org/2654133003 . Cr-Commit-Position: refs/branch-heads/2987@{#95} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/ca1fbefb12a1ac5ef98a739e9659a8e0c1e976ba

Patch Set 1 #

Messages

Total messages: 2 (1 generated)
Rick Byers
3 years, 11 months ago (2017-01-25 21:14:35 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ca1fbefb12a1ac5ef98a739e9659a8e0c1e976ba.

Powered by Google App Engine
This is Rietveld 408576698