harmony: partly harmonize permissions bubble

chrome/browser/ui/views/harmony/layout_delegate.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_HARMONY_LAYOUT_DELEGATE_H_
 #define CHROME_BROWSER_UI_VIEWS_HARMONY_LAYOUT_DELEGATE_H_
 
 #include "ui/views/layout/grid_layout.h"
 
 class LayoutDelegate {
@@ skipping 12 matching lines @@
     // Vertical spacing between controls that are logically unrelated.
     UNRELATED_CONTROL_VERTICAL_SPACING,
     // Larger vertical spacing between unrelated controls.
     UNRELATED_CONTROL_LARGE_VERTICAL_SPACING,
     // Vertical spacing between the edge of the window and the
     // top or bottom of a button.
     BUTTON_HEDGE_MARGIN_NEW,
     // Horizontal spacing between the edge of the window and the
     // left or right of a button.
     BUTTON_VEDGE_MARGIN_NEW,
-    // Indent of checkboxes relative to related text.
-    CHECKBOX_INDENT,
+    // Indent of subsections (related checkboxes or similar)  relative to
+    // related text.
+    SUBSECTION_INDENT,

[Peter Kasting, 2017/02/01 02:20:20]

I liked your use of SUBSECTION here, so I adopted it in
https://codereview.chromium.org/2666043002/ .  I added HORIZONTAL_ there as
well.  Once that change lands (in CQ as I write this), you'll want to revert
this piece of this change, and update the rest of your patch to use that name.

+    // Horizontal spacing between a control and its label.
+    ITEM_LABEL_SPACING,

[Peter Kasting, 2017/02/01 02:20:20]

I also found a need for this constant locally, so adding this seems good.  In my
checkout (not yet up for review), I picked this name and comment, for
parallelism with the other names above (and I put this in alphabetical order
with them).  WDYT?

    // Horizontal spacing between an item such as an icon or checkbox and a
    // label related to it.
    RELATED_LABEL_HORIZONTAL_SPACING,

   };
 
   enum class DialogWidthType {
     SMALL,
     MEDIUM,
     LARGE,
   };
 
   LayoutDelegate() {}
   virtual ~LayoutDelegate() {}
@@ skipping 28 matching lines @@
 
   // Returns the preferred width for a dialog of the specified width type. If
   // there is no preferred width for |type|, returns 0.
   virtual int GetDialogPreferredWidth(DialogWidthType type) const;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(LayoutDelegate);
 };
 
 #endif  // CHROME_BROWSER_UI_VIEWS_HARMONY_LAYOUT_DELEGATE_H_