Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2654093006: WebAPKs: Fix play-install variations check (Closed)

Created:
3 years, 11 months ago by pkotwicz
Modified:
3 years, 11 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

WebAPKs: Fix play-install variations check This CL: 1) Fixes ChromeWebApkHost#canUseGooglePlayToInstallWebApk() to use variations::GetVariationParamValueByFeature() instead of variations::GetVariationParamValue(). This matches the server side variations configuration. 2) Updates the cached value of whether WebAPKs are enabled (Returned by ChromeWebApkHost#isEnabled()) prior to calling ChromeWebApkHost#canUseGooglePlayToInstallWebApk(). BUG=684804 Review-Url: https://codereview.chromium.org/2655803002 Cr-Commit-Position: refs/heads/master@{#446097} (cherry picked from commit 2a1ffdc2376233aaef5110a1c406a50539a795bd) Review-Url: https://codereview.chromium.org/2654093006 . Cr-Commit-Position: refs/branch-heads/2987@{#129} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/c99788f98ca6aba368c4dc1431ddae2a9ccdbb26

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -10 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/webapps/ChromeWebApkHost.java View 5 chunks +8 lines, -10 lines 0 comments Download
M chrome/browser/android/chrome_jni_registrar.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/android/webapk/chrome_webapk_host.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/android/webapk/chrome_webapk_host.cc View 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
pkotwicz
3 years, 11 months ago (2017-01-26 23:34:47 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c99788f98ca6aba368c4dc1431ddae2a9ccdbb26.

Powered by Google App Engine
This is Rietveld 408576698