ui/views/controls/menu/menu_runner_impl.h - Issue 2654093005: Fix MenuRunner Releasing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/menu/menu_runner_impl.h

Issue 2654093005: Fix MenuRunner Releasing (Closed)

Patch Set: Clarification and renaming Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/controls/menu/menu_runner_impl.h

diff --git a/ui/views/controls/menu/menu_runner_impl.h b/ui/views/controls/menu/menu_runner_impl.h

index a113d09c09ef868438941c3850205c35b79ceed4..8312f428e040741f0ab610aedbe22f3fa396de50 100644

--- a/ui/views/controls/menu/menu_runner_impl.h

+++ b/ui/views/controls/menu/menu_runner_impl.h

@@ -86,7 +86,7 @@ class VIEWS_EXPORT MenuRunnerImpl

bool for_drop_;

// The controller.

- MenuController* controller_;

+ base::WeakPtr<MenuController> controller_;

// Do we own the controller?

bool owns_controller_;