Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Side by Side Diff: ui/views/controls/menu/menu_runner_impl.h

Issue 2654093005: Fix MenuRunner Releasing (Closed)
Patch Set: Clarification and renaming Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ui/views/controls/menu/menu_controller.cc ('k') | ui/views/controls/menu/menu_runner_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef UI_VIEWS_CONTROLS_MENU_MENU_RUNNER_IMPL_H_ 5 #ifndef UI_VIEWS_CONTROLS_MENU_MENU_RUNNER_IMPL_H_
6 #define UI_VIEWS_CONTROLS_MENU_MENU_RUNNER_IMPL_H_ 6 #define UI_VIEWS_CONTROLS_MENU_MENU_RUNNER_IMPL_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <set> 10 #include <set>
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
79 // Set if |running_| and Release() has been invoked. 79 // Set if |running_| and Release() has been invoked.
80 bool delete_after_run_; 80 bool delete_after_run_;
81 81
82 // Are we running asynchronously? 82 // Are we running asynchronously?
83 bool async_; 83 bool async_;
84 84
85 // Are we running for a drop? 85 // Are we running for a drop?
86 bool for_drop_; 86 bool for_drop_;
87 87
88 // The controller. 88 // The controller.
89 MenuController* controller_; 89 base::WeakPtr<MenuController> controller_;
90 90
91 // Do we own the controller? 91 // Do we own the controller?
92 bool owns_controller_; 92 bool owns_controller_;
93 93
94 // The timestamp of the event which closed the menu - or 0. 94 // The timestamp of the event which closed the menu - or 0.
95 base::TimeTicks closing_event_time_; 95 base::TimeTicks closing_event_time_;
96 96
97 // Used to detect deletion of |this| when notifying delegate of success. 97 // Used to detect deletion of |this| when notifying delegate of success.
98 base::WeakPtrFactory<MenuRunnerImpl> weak_factory_; 98 base::WeakPtrFactory<MenuRunnerImpl> weak_factory_;
99 99
100 DISALLOW_COPY_AND_ASSIGN(MenuRunnerImpl); 100 DISALLOW_COPY_AND_ASSIGN(MenuRunnerImpl);
101 }; 101 };
102 102
103 } // namespace internal 103 } // namespace internal
104 } // namespace views 104 } // namespace views
105 105
106 #endif // UI_VIEWS_CONTROLS_MENU_MENU_RUNNER_IMPL_H_ 106 #endif // UI_VIEWS_CONTROLS_MENU_MENU_RUNNER_IMPL_H_
OLDNEW
« no previous file with comments | « ui/views/controls/menu/menu_controller.cc ('k') | ui/views/controls/menu/menu_runner_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698