Revert of Fix TemplateUrl::MatchesData comparison of search_terms_replacement_key

Revert of Fix TemplateUrl::MatchesData comparison of search_terms_replacement_key (patchset #2 id:20001 of https://codereview.chromium.org/2516963002/ )

Reason for revert:
Part 2 of 2: Reverting change that caused bug 680197

Original issue's description:
> Fix TemplateUrl::MatchesData comparison of search_terms_replacement_key
> 
> Current TemplateUrl constructor performs replacement of
> search_terms_replacement_key field after initialization from
> TemplateURLData. This replacement was not handled correctly in
> TemplateUrl::MatchesData function. As result, TemplateUrl created from
> TemplateUrlData for google engine could not be matched to its own
> source data.
> 
> R=pkasting@chromium.org
> 
> Committed: https://crrev.com/58606e51c44b74f89cf5fbbb370a78731acd942a
> Cr-Commit-Position: refs/heads/master@{#433504}

TBR=treib@chromium.org,a-v-y@yandex-team.ru
# Not skipping CQ checks because original CL landed more than 1 days ago.

Review-Url: https://codereview.chromium.org/2654093004
Cr-Commit-Position: refs/heads/master@{#446914}
Committed: https://chromium.googlesource.com/chromium/src/+/db0955098c346ad7eeb0136df88a932cec24c7ba

[Peter Kasting, 2017-01-25 23:54:10]

The CQ bit was checked by pkasting@chromium.org

[Peter Kasting, 2017-01-25 23:54:10]

Created Revert of Fix TemplateUrl::MatchesData comparison of
search_terms_replacement_key

[commit-bot: I haz the power, 2017-01-25 23:54:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-26 02:46:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-26 02:46:15]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Alexander Yashkin, 2017-01-26 05:24:29]

lgtm

[Alexander Yashkin, 2017-01-28 06:42:20]

On 2017/01/26 at 05:24:29, Alexander Yashkin wrote:
> lgtm

@pkasting, this revert was not commited because of tests failure.
I cant find test logs, so i am not sure what the reason of this.

[Peter Kasting, 2017-01-28 06:56:10]

The CQ bit was checked by pkasting@chromium.org

[commit-bot: I haz the power, 2017-01-28 06:56:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Peter Kasting, 2017-01-28 06:56:57]

On 2017/01/28 06:42:20, Alexander Yashkin wrote:
> On 2017/01/26 at 05:24:29, Alexander Yashkin wrote:
> > lgtm
> 
> @pkasting, this revert was not commited because of tests failure.

Oops, thanks for flagging.  Purple means infrastructure failure, so I'll simply
retry.

I was wondering why I didn't see an update about this, but kept forgetting to
check into it.

[Alexander Yashkin, 2017-01-28 07:20:23]

On 2017/01/28 at 06:56:57, pkasting wrote:
> On 2017/01/28 06:42:20, Alexander Yashkin wrote:
> > On 2017/01/26 at 05:24:29, Alexander Yashkin wrote:
> > > lgtm
> > 
> > @pkasting, this revert was not commited because of tests failure.
> 
> Oops, thanks for flagging.  Purple means infrastructure failure, so I'll
simply retry.
> 
> I was wondering why I didn't see an update about this, but kept forgetting to
check into it.

Created https://bugs.chromium.org/p/chromium/issues/detail?id=686399

[commit-bot: I haz the power, 2017-01-28 07:43:33]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1485586570143910, "parent_rev":
"9c70d2d09ae97fcef450d25b536b993272e27a52", "commit_rev":
"db0955098c346ad7eeb0136df88a932cec24c7ba"}

[commit-bot: I haz the power, 2017-01-28 07:44:16]

Description was changed from

==========
Revert of Fix TemplateUrl::MatchesData comparison of
search_terms_replacement_key (patchset #2 id:20001 of
https://codereview.chromium.org/2516963002/ )

Reason for revert:
Part 2 of 2: Reverting change that caused bug 680197

Original issue's description:
> Fix TemplateUrl::MatchesData comparison of search_terms_replacement_key
> 
> Current TemplateUrl constructor performs replacement of
> search_terms_replacement_key field after initialization from
> TemplateURLData. This replacement was not handled correctly in
> TemplateUrl::MatchesData function. As result, TemplateUrl created from
> TemplateUrlData for google engine could not be matched to its own
> source data.
> 
> R=pkasting@chromium.org
> 
> Committed: https://crrev.com/58606e51c44b74f89cf5fbbb370a78731acd942a
> Cr-Commit-Position: refs/heads/master@{#433504}

TBR=treib@chromium.org,a-v-y@yandex-team.ru
# Not skipping CQ checks because original CL landed more than 1 days ago.
==========

to

==========
Revert of Fix TemplateUrl::MatchesData comparison of
search_terms_replacement_key (patchset #2 id:20001 of
https://codereview.chromium.org/2516963002/ )

Reason for revert:
Part 2 of 2: Reverting change that caused bug 680197

Original issue's description:
> Fix TemplateUrl::MatchesData comparison of search_terms_replacement_key
> 
> Current TemplateUrl constructor performs replacement of
> search_terms_replacement_key field after initialization from
> TemplateURLData. This replacement was not handled correctly in
> TemplateUrl::MatchesData function. As result, TemplateUrl created from
> TemplateUrlData for google engine could not be matched to its own
> source data.
> 
> R=pkasting@chromium.org
> 
> Committed: https://crrev.com/58606e51c44b74f89cf5fbbb370a78731acd942a
> Cr-Commit-Position: refs/heads/master@{#433504}

TBR=treib@chromium.org,a-v-y@yandex-team.ru
# Not skipping CQ checks because original CL landed more than 1 days ago.

Review-Url: https://codereview.chromium.org/2654093004
Cr-Commit-Position: refs/heads/master@{#446914}
Committed:
https://chromium.googlesource.com/chromium/src/+/db0955098c346ad7eeb0136df88a...
==========

[commit-bot: I haz the power, 2017-01-28 07:44:17]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/db0955098c346ad7eeb0136df88a...