Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 2654073003: WebUI: Update vulcanize.py to not process Downloads page anymore. (Closed)

Created:
3 years, 11 months ago by dpapad
Modified:
3 years, 11 months ago
Reviewers:
Dan Beam
CC:
arv+watch_chromium.org, chromium-reviews, scottchen
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

WebUI: Update vulcanize.py to not process Downloads page anymore. BUG=673825 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2654073003 Cr-Commit-Position: refs/heads/master@{#446132} Committed: https://chromium.googlesource.com/chromium/src/+/18a4bda779e6b2d09a6dac1bdfe86a4732892e8a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M chrome/browser/resources/vulcanize.py View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
dpapad
Is there any reason to keep processing Downloads from the old vulcanize.py? I think this ...
3 years, 11 months ago (2017-01-25 21:36:20 UTC) #3
Dan Beam
you beat me to it ;)
3 years, 11 months ago (2017-01-25 21:39:56 UTC) #4
Dan Beam
lgtm
3 years, 11 months ago (2017-01-25 21:39:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2654073003/1
3 years, 11 months ago (2017-01-25 21:43:00 UTC) #7
commit-bot: I haz the power
3 years, 11 months ago (2017-01-25 21:57:45 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/18a4bda779e6b2d09a6dac1bdfe8...

Powered by Google App Engine
This is Rietveld 408576698