Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2654063004: Remove uses of private web API in ios/web_view. (Closed)

Created:
3 years, 11 months ago by michaeldo
Modified:
3 years, 11 months ago
CC:
chromium-reviews, Eugene But (OOO till 7-30)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove uses of private web API in ios/web_view. BUG=622967 Review-Url: https://codereview.chromium.org/2654063004 Cr-Commit-Position: refs/heads/master@{#446149} Committed: https://chromium.googlesource.com/chromium/src/+/d77dd516d0284768f180ec1472a6bd37d0ed8974

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -125 lines) Patch
M ios/web_view/internal/DEPS View 1 chunk +0 lines, -5 lines 0 comments Download
M ios/web_view/internal/criwv_web_view_impl.mm View 5 chunks +38 lines, -114 lines 0 comments Download
M ios/web_view/public/criwv_web_view_delegate.h View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
michaeldo
Note that a method is removed from CRIWVWebViewDelegate, but may be re-added in the near ...
3 years, 11 months ago (2017-01-25 22:11:30 UTC) #2
Eugene But (OOO till 7-30)
lgtm
3 years, 11 months ago (2017-01-25 22:20:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2654063004/1
3 years, 11 months ago (2017-01-25 22:22:57 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-25 22:56:55 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d77dd516d0284768f180ec1472a6...

Powered by Google App Engine
This is Rietveld 408576698