Move impl of identity.LaunchWebAuthFlow() extension API to its own file

Move impl of identity.LaunchWebAuthFlow() extension API to its own file

As a precursor to a refactoring of the identity extension API implementation
to use the Identity Service, I am moving the implementations of the six
identity extension API functions to their own files, rather than all
being lumped together in identity_api.*. This will make it easier to
analyze each of these function implementations independently and
incrementally convert them to use the Identity Service.

BUG=685654
Review-Url: https://codereview.chromium.org/2654023005
Cr-Commit-Position: refs/heads/master@{#446627}
Committed: https://chromium.googlesource.com/chromium/src/+/1915164756cbde01d3c694435dfa30a7742fa7d3

[blundell, 2017-01-26 16:26:44]

The CQ bit was checked by blundell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-26 16:27:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[blundell, 2017-01-26 17:01:41]

blundell@chromium.org changed reviewers:
+ rockot@chromium.org

[blundell, 2017-01-26 17:01:42]

Hi Ken,

Sending this out before the trybots finish as it's the end of my day and I'd
like to get your feedback early on whether this restructuring breaks any
unwritten laws or conventions on how the extension API impls work (this is the
first time I've worked with this part of the codebase at all).

[commit-bot: I haz the power, 2017-01-26 17:56:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-26 17:56:13]

Dry run: This issue passed the CQ dry run.

[Ken Rockot(use gerrit already), 2017-01-26 23:56:49]

LGTM - Yeah this is fine since you include the new header from identity_api.h
(which is in turn included by generated code which registers all the API
function classes)

[blundell, 2017-01-27 08:46:30]

On 2017/01/26 23:56:49, Ken Rockot wrote:
> LGTM - Yeah this is fine since you include the new header from identity_api.h
> (which is in turn included by generated code which registers all the API
> function classes)

Thanks! Yes, I got to discover exactly how that machinery works, as I had to
track down the compile failure in generated_api_registration.cc that occurred
when I moved this function out of identity_api.* :).

[blundell, 2017-01-27 08:46:35]

The CQ bit was checked by blundell@chromium.org

[commit-bot: I haz the power, 2017-01-27 08:46:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 08:50:59]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1485506795498840, "parent_rev":
"74db8fde1d17bae57091542a923add41faf344ff", "commit_rev":
"1915164756cbde01d3c694435dfa30a7742fa7d3"}

[commit-bot: I haz the power, 2017-01-27 08:52:23]

Description was changed from

==========
Move impl of identity.LaunchWebAuthFlow() extension API to its own file

As a precursor to a refactoring of the identity extension API implementation
to use the Identity Service, I am moving the implementations of the six
identity extension API functions to their own files, rather than all
being lumped together in identity_api.*. This will make it easier to
analyze each of these function implementations independently and
incrementally convert them to use the Identity Service.

BUG=685654
==========

to

==========
Move impl of identity.LaunchWebAuthFlow() extension API to its own file

As a precursor to a refactoring of the identity extension API implementation
to use the Identity Service, I am moving the implementations of the six
identity extension API functions to their own files, rather than all
being lumped together in identity_api.*. This will make it easier to
analyze each of these function implementations independently and
incrementally convert them to use the Identity Service.

BUG=685654

Review-Url: https://codereview.chromium.org/2654023005
Cr-Commit-Position: refs/heads/master@{#446627}
Committed:
https://chromium.googlesource.com/chromium/src/+/1915164756cbde01d3c694435dfa...
==========

[commit-bot: I haz the power, 2017-01-27 08:52:24]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1915164756cbde01d3c694435dfa...