Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 2654003007: [Android] Enable Ad Hoc RemoteViews in CCT Bottom Bar (Closed)

Created:
3 years, 11 months ago by Ian Wen
Modified:
3 years, 11 months ago
Reviewers:
Yusuf
CC:
chromium-reviews, lizeb+watch-custom-tabs_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Enable Ad Hoc RemoteViews in CCT Bottom Bar This CL makes it possible for client to add a RemoteViews bottom bar through CustomTabsSession. BUG=680189 Review-Url: https://codereview.chromium.org/2654003007 Cr-Commit-Position: refs/heads/master@{#446445} Committed: https://chromium.googlesource.com/chromium/src/+/ffbe56aa8a82dd68bba0912cfb6b944415ed5fd6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabBottomBarDelegate.java View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Ian Wen
3 years, 11 months ago (2017-01-26 19:11:43 UTC) #2
Yusuf
lgtm
3 years, 11 months ago (2017-01-26 20:47:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2654003007/1
3 years, 11 months ago (2017-01-26 21:02:48 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-26 21:07:59 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ffbe56aa8a82dd68bba0912cfb6b...

Powered by Google App Engine
This is Rietveld 408576698