Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 2653953010: [turbofan] No longer ignore FrameState input to Call (Closed)

Created:
3 years, 10 months ago by Tobias Tebbi
Modified:
3 years, 10 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] No longer ignore FrameState input to Call R=mstarzinger@chromium.org BUG=chromium:683566 Review-Url: https://codereview.chromium.org/2653953010 Cr-Commit-Position: refs/heads/master@{#42737} Committed: https://chromium.googlesource.com/v8/v8/+/c1a43ff9960019cba80ea7ab6af24d50e8bca89b

Patch Set 1 #

Total comments: 1

Patch Set 2 : addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -1 line) Patch
M src/compiler/escape-analysis.cc View 1 3 chunks +15 lines, -1 line 0 comments Download
A test/mjsunit/compiler/escape-analysis-11.js View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Tobias Tebbi
3 years, 10 months ago (2017-01-27 11:33:26 UTC) #1
Michael Starzinger
LGTM. Thanks! https://codereview.chromium.org/2653953010/diff/1/src/compiler/escape-analysis.cc File src/compiler/escape-analysis.cc (right): https://codereview.chromium.org/2653953010/diff/1/src/compiler/escape-analysis.cc#newcode1074 src/compiler/escape-analysis.cc:1074: if (op->opcode() == IrOpcode::kCall) { nit: Even ...
3 years, 10 months ago (2017-01-27 11:36:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2653953010/20001
3 years, 10 months ago (2017-01-27 12:05:43 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-01-27 12:40:10 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/c1a43ff9960019cba80ea7ab6af24d50e8b...

Powered by Google App Engine
This is Rietveld 408576698