Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3554)

Unified Diff: chrome/browser/ui/webui/signin/inline_login_handler_impl.h

Issue 2653953009: Convert InlineLoginHandlerImpl to use the new navigation callbacks. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/signin/inline_login_handler_impl.h
diff --git a/chrome/browser/ui/webui/signin/inline_login_handler_impl.h b/chrome/browser/ui/webui/signin/inline_login_handler_impl.h
index 8a71c14817bec87d38d15824c250d43d3fbc9cc3..896689a236f200c4e6e2f37b11013987aec35426 100644
--- a/chrome/browser/ui/webui/signin/inline_login_handler_impl.h
+++ b/chrome/browser/ui/webui/signin/inline_login_handler_impl.h
@@ -118,10 +118,8 @@ class InlineLoginHandlerImpl : public InlineLoginHandler,
Profile::CreateStatus status);
// Overridden from content::WebContentsObserver overrides.
achuithb 2017/01/27 01:11:16 This comment appears overly verbose if you want to
jam 2017/01/27 01:39:05 Done.
- void DidCommitProvisionalLoadForFrame(
- content::RenderFrameHost* render_frame_host,
- const GURL& url,
- ui::PageTransition transition_type) override;
+ void DidFinishNavigation(
+ content::NavigationHandle* navigation_handle) override;
// True if the user has navigated to untrusted domains during the signin
// process.

Powered by Google App Engine
This is Rietveld 408576698