[ast] Temporarily allow handle dereference for debug printing

[ast] Temporarily allow handle dereference for debug printing

There is a print in AstNumbering which needs to dereference the string
containing the function name, which clashes with the disallowed handle
reference scope used to allow ast-numbering to run off-thread.

This could be fixed by pushing the print out of this function, and
somehow propagating disable_crankshaft_reason out of the visitor, but in
reality this check will soon be removed anyway, and until it is this
function will be on the main thread, so we may as well just hack it.

Review-Url: https://codereview.chromium.org/2653953006
Cr-Commit-Position: refs/heads/master@{#42711}
Committed: https://chromium.googlesource.com/v8/v8/+/ba1d747d6fb2419b7ac4904dd7f47422471d3b86

[Leszek Swirski, 2017-01-25 19:51:24]

The CQ bit was checked by leszeks@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-25 19:51:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Leszek Swirski, 2017-01-25 19:52:15]

leszeks@chromium.org changed reviewers:
+ ishell@chromium.org, marja@chromium.org

[Leszek Swirski, 2017-01-25 19:52:16]

marja: Please review.
ishell: FYI.

[commit-bot: I haz the power, 2017-01-25 19:54:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-25 19:54:01]

Dry run: Try jobs failed on following builders:
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/19920)
  v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/19993)
  v8_win64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/21548)
  v8_win_compile_dbg on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/3...)
  v8_win_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/21636)

[Leszek Swirski, 2017-01-25 19:58:15]

The CQ bit was checked by leszeks@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-25 19:58:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 20:30:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-25 20:30:07]

Dry run: This issue passed the CQ dry run.

[marja, 2017-01-26 08:38:11]

lgtm

[Leszek Swirski, 2017-01-26 18:41:05]

The CQ bit was checked by leszeks@chromium.org

[commit-bot: I haz the power, 2017-01-26 18:41:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-26 18:43:07]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485456065065640,
"parent_rev": "70fdac9a642154307fa461b2aae38942600c9623", "commit_rev":
"ba1d747d6fb2419b7ac4904dd7f47422471d3b86"}

[commit-bot: I haz the power, 2017-01-26 18:43:12]

Description was changed from

==========
[ast] Temporarily allow handle dereference for debug printing

There is a print in AstNumbering which needs to dereference the string
containing the function name, which clashes with the disallowed handle
reference scope used to allow ast-numbering to run off-thread.

This could be fixed by pushing the print out of this function, and
somehow propagating disable_crankshaft_reason out of the visitor, but in
reality this check will soon be removed anyway, and until it is this
function will be on the main thread, so we may as well just hack it.
==========

to

==========
[ast] Temporarily allow handle dereference for debug printing

There is a print in AstNumbering which needs to dereference the string
containing the function name, which clashes with the disallowed handle
reference scope used to allow ast-numbering to run off-thread.

This could be fixed by pushing the print out of this function, and
somehow propagating disable_crankshaft_reason out of the visitor, but in
reality this check will soon be removed anyway, and until it is this
function will be on the main thread, so we may as well just hack it.

Review-Url: https://codereview.chromium.org/2653953006
Cr-Commit-Position: refs/heads/master@{#42711}
Committed:
https://chromium.googlesource.com/v8/v8/+/ba1d747d6fb2419b7ac4904dd7f47422471...
==========

[commit-bot: I haz the power, 2017-01-26 18:43:13]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/ba1d747d6fb2419b7ac4904dd7f47422471...