Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(728)

Issue 2653953004: Revert of Make DirectX Capturer Default On (Closed)

Created:
3 years, 10 months ago by qiangchen
Modified:
3 years, 10 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, xjz+watch_chromium.org, miu+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Make DirectX Capturer Default On (patchset #1 id:1 of https://codereview.chromium.org/2606783002/ ) Reason for revert: Several bugs are found with DirectX Capturer. Original issue's description: > Make DirectX Capturer Default On > > After monitoring the finch alert for a month, we found the DirectX Capturer works well. This CL brings flag to be default enabled. > > BUG=314516 > > Committed: https://crrev.com/cc10ca6c0767a9b1c4d7e4b9bad73cd8fa1140c6 > Cr-Commit-Position: refs/heads/master@{#440856} TBR=sergeyu@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=314516, 682112 Review-Url: https://codereview.chromium.org/2653953004 Cr-Commit-Position: refs/heads/master@{#446068} Committed: https://chromium.googlesource.com/chromium/src/+/7a635db552dea8279eb7655e876555fad7e3aea2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/browser/media/capture/desktop_capture_device.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
qiangchen
Created Revert of Make DirectX Capturer Default On
3 years, 10 months ago (2017-01-25 17:32:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2653953004/1
3 years, 10 months ago (2017-01-25 17:32:36 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/7a635db552dea8279eb7655e876555fad7e3aea2
3 years, 10 months ago (2017-01-25 18:51:54 UTC) #7
qiangchen
3 years, 10 months ago (2017-02-23 17:58:06 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2716663002/ by qiangchen@chromium.org.

The reason for reverting is: Bring the flag on by default for testing purpose..

Powered by Google App Engine
This is Rietveld 408576698