third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurface.h - Issue 2653933003: Make stream captures work on canvases that are not in the DOM.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurface.h

Issue 2653933003: Make stream captures work on canvases that are not in the DOM. (Closed)

Patch Set: fix test + review comments Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/graphics/ImageBuffer.cpp ('K') | « third_party/WebKit/Source/platform/graphics/ImageBufferSurface.h ('k') | third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurface.cpp » ('j') | third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurface.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurface.h

diff --git a/third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurface.h b/third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurface.h

index 56837a82ef36abaaf3139f3ea51304b7952ae320..ee320385456b790d05883592324af83cf1a9df2c 100644

--- a/third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurface.h

+++ b/third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurface.h

@@ -65,7 +65,8 @@ class PLATFORM_EXPORT RecordingImageBufferSurface : public ImageBufferSurface {

int x,

int y) override;

void willOverwriteCanvas() override;

- virtual void finalizeFrame(const FloatRect&);

+ void finalizeFrame() override;

+ void doPaintInvalidation(const FloatRect&) override;

void setImageBuffer(ImageBuffer*) override;

sk_sp<SkImage> newImageSnapshot(AccelerationHint, SnapshotReason) override;

void draw(GraphicsContext&,