third_party/WebKit/Source/platform/graphics/ImageBufferSurface.h - Issue 2653933003: Make stream captures work on canvases that are not in the DOM.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/ImageBufferSurface.h

Issue 2653933003: Make stream captures work on canvases that are not in the DOM. (Closed)

Patch Set: fix test + review comments Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/graphics/ImageBufferSurface.h

diff --git a/third_party/WebKit/Source/platform/graphics/ImageBufferSurface.h b/third_party/WebKit/Source/platform/graphics/ImageBufferSurface.h

index 77c6956dc6a8cb6ac238225cd6c8b76c2fbb8d8f..3034747902db210771124cb804726595c14a72fa 100644

--- a/third_party/WebKit/Source/platform/graphics/ImageBufferSurface.h

+++ b/third_party/WebKit/Source/platform/graphics/ImageBufferSurface.h

@@ -75,7 +75,8 @@ class PLATFORM_EXPORT ImageBufferSurface {

virtual void setIsHidden(bool) {}

virtual void setImageBuffer(ImageBuffer*) {}

virtual sk_sp<PaintRecord> getPicture();

- virtual void finalizeFrame(const FloatRect& dirtyRect) {}

+ virtual void finalizeFrame() {}

+ virtual void doPaintInvalidation(const FloatRect& dirtyRect) {}

virtual void draw(GraphicsContext&,

const FloatRect& destRect,

const FloatRect& srcRect,