Upstream IndexedDB exception ordering tests to WPT.

Upstream IndexedDB exception ordering tests to WPT.

BUG=683463
Review-Url: https://codereview.chromium.org/2653923007
Cr-Commit-Position: refs/heads/master@{#447075}
Committed: https://chromium.googlesource.com/chromium/src/+/051af499c75a07cfb51cdfa20a2b6ef6d941924f

[pwnall, 2017-01-28 02:32:42]

The CQ bit was checked by pwnall@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-28 02:33:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pwnall, 2017-01-28 02:38:36]

pwnall@chromium.org changed reviewers:
+ jsbell@chromium.org

[pwnall, 2017-01-28 02:38:37]

PTAL?

The tests are straightforward imports, except that I flipped the order of `put`
and `add` in idbobjectstore-add-put-exception-order.html to match the spec
order.

idbdatabase-transaction-exception-order doesn't check for the ordering of
TypeError vs InvalidStateError. It seems to me that it'd be better to add this
in a separate CL, so the diff here remains obvious.

Also, we don't seem to have an idbobjectstore-createIndex-exception-order test.
I'm not sure if that matters... but if it does, I can add a test in a later CL.

[pwnall, 2017-01-28 02:40:04]

Description was changed from

==========
Upstream IndexedDB exception ordering tests to WPT.

BUG=683463
==========

to

==========
Upstream IndexedDB exception ordering tests to WPT.

BUG=683463
==========

[commit-bot: I haz the power, 2017-01-28 04:01:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-28 04:01:21]

Dry run: This issue passed the CQ dry run.

[jsbell, 2017-01-30 17:52:04]

lgtm

[jsbell, 2017-01-30 17:52:52]

On 2017/01/28 02:38:37, pwnall wrote:
> idbdatabase-transaction-exception-order doesn't check for the ordering of
> TypeError vs InvalidStateError. It seems to me that it'd be better to add this
> in a separate CL, so the diff here remains obvious.

sgtm
 
> Also, we don't seem to have an idbobjectstore-createIndex-exception-order
test.
> I'm not sure if that matters... but if it does, I can add a test in a later
CL.

Hrm, that's suspicious. Not even upstream already?

Anyway, yeah, later CL.

[pwnall, 2017-01-30 18:26:56]

The CQ bit was checked by pwnall@chromium.org

[pwnall, 2017-01-30 18:27:11]

On 2017/01/30 17:52:52, jsbell wrote:
> On 2017/01/28 02:38:37, pwnall wrote:
> > idbdatabase-transaction-exception-order doesn't check for the ordering of
> > TypeError vs InvalidStateError. It seems to me that it'd be better to add
this
> > in a separate CL, so the diff here remains obvious.
> 
> sgtm
>  
> > Also, we don't seem to have an idbobjectstore-createIndex-exception-order
> test.
> > I'm not sure if that matters... but if it does, I can add a test in a later
> CL.
> 
> Hrm, that's suspicious. Not even upstream already?
> 
> Anyway, yeah, later CL.

Thank you very much for the quick review!

[commit-bot: I haz the power, 2017-01-30 18:27:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-30 18:30:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-30 18:30:33]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[pwnall, 2017-01-30 20:16:25]

The CQ bit was checked by pwnall@chromium.org

[pwnall, 2017-01-30 20:16:26]

The patchset sent to the CQ was uploaded after l-g-t-m from jsbell@chromium.org
Link to the patchset: https://codereview.chromium.org/2653923007/#ps20001
(title: "Rebased MANIFEST.json")

[commit-bot: I haz the power, 2017-01-30 20:17:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-30 21:42:43]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485807385925720,
"parent_rev": "e04864cab7755bdc01abf0431cfd825d488b309c", "commit_rev":
"051af499c75a07cfb51cdfa20a2b6ef6d941924f"}

[commit-bot: I haz the power, 2017-01-30 21:43:22]

Description was changed from

==========
Upstream IndexedDB exception ordering tests to WPT.

BUG=683463
==========

to

==========
Upstream IndexedDB exception ordering tests to WPT.

BUG=683463

Review-Url: https://codereview.chromium.org/2653923007
Cr-Commit-Position: refs/heads/master@{#447075}
Committed:
https://chromium.googlesource.com/chromium/src/+/051af499c75a07cfb51cdfa20a2b...
==========

[commit-bot: I haz the power, 2017-01-30 21:43:23]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/051af499c75a07cfb51cdfa20a2b...