X87: [TypeFeedbackVector] DeclareGlobals needs a literals array.

X87: [TypeFeedbackVector] DeclareGlobals needs a literals array.

  port d287c8196990b04169d5dc4e9cf6eb03d88d9e47 (r42620)

  original commit message:
  [RELAND with one change: until literal arrays are rooted in the outer
  feedback vector (coming in the next days), the runtime-scope.cc change
  is held off.]

  When a function is declared in global scope, the closure is created
  by the DeclareGlobals runtime service. It needs a pointer to the
  literals array, already allocated in the feedback vector. This
  fixes a bug where it's behavior wasn't in sync with CreateClosure,
  which accepts the literals from the vector.

  This enables a follow-on performance improvement in the CompileLazy
  builtin.

BUG=

Review-Url: https://codereview.chromium.org/2653893002
Cr-Commit-Position: refs/heads/master@{#42641}
Committed: https://chromium.googlesource.com/v8/v8/+/f223d4f5bef79ef5b9eb0dfc8f194d49b4600aad

[zhengxing.li, 2017-01-24 11:02:19]

zhengxing.li@intel.com changed reviewers:
+ chunyang.dai@intel.com, mvstanton@chromium.org

[zhengxing.li, 2017-01-24 11:02:19]

PTAL, thanks!

[chunyang.dai, 2017-01-25 04:41:52]

On 2017/01/24 11:02:19, zhengxing.li wrote:
> PTAL, thanks!

LGTM.
thanks

[zhengxing.li, 2017-01-25 04:59:30]

The CQ bit was checked by zhengxing.li@intel.com

[commit-bot: I haz the power, 2017-01-25 04:59:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 05:23:14]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1485320370616950, "parent_rev":
"e5608155aeb18a76fdb495d446efe1f9e33e749b", "commit_rev":
"f223d4f5bef79ef5b9eb0dfc8f194d49b4600aad"}

[commit-bot: I haz the power, 2017-01-25 05:23:17]

Description was changed from

==========
X87: [TypeFeedbackVector] DeclareGlobals needs a literals array.

  port d287c8196990b04169d5dc4e9cf6eb03d88d9e47 (r42620)

  original commit message:
  [RELAND with one change: until literal arrays are rooted in the outer
  feedback vector (coming in the next days), the runtime-scope.cc change
  is held off.]

  When a function is declared in global scope, the closure is created
  by the DeclareGlobals runtime service. It needs a pointer to the
  literals array, already allocated in the feedback vector. This
  fixes a bug where it's behavior wasn't in sync with CreateClosure,
  which accepts the literals from the vector.

  This enables a follow-on performance improvement in the CompileLazy
  builtin.

BUG=
==========

to

==========
X87: [TypeFeedbackVector] DeclareGlobals needs a literals array.

  port d287c8196990b04169d5dc4e9cf6eb03d88d9e47 (r42620)

  original commit message:
  [RELAND with one change: until literal arrays are rooted in the outer
  feedback vector (coming in the next days), the runtime-scope.cc change
  is held off.]

  When a function is declared in global scope, the closure is created
  by the DeclareGlobals runtime service. It needs a pointer to the
  literals array, already allocated in the feedback vector. This
  fixes a bug where it's behavior wasn't in sync with CreateClosure,
  which accepts the literals from the vector.

  This enables a follow-on performance improvement in the CompileLazy
  builtin.

BUG=

Review-Url: https://codereview.chromium.org/2653893002
Cr-Commit-Position: refs/heads/master@{#42641}
Committed:
https://chromium.googlesource.com/v8/v8/+/f223d4f5bef79ef5b9eb0dfc8f194d49b46...
==========

[commit-bot: I haz the power, 2017-01-25 05:23:18]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/f223d4f5bef79ef5b9eb0dfc8f194d49b46...