Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2653843003: Move arch+plat logic to common. (Closed)

Created:
3 years, 11 months ago by iannucci
Modified:
3 years, 11 months ago
Reviewers:
Vadim Sh.
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -19 lines) Patch
M cipd/client/cipd/client.go View 1 4 chunks +6 lines, -19 lines 0 comments Download
M cipd/client/cipd/common/common.go View 2 chunks +33 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (4 generated)
iannucci
3 years, 11 months ago (2017-01-24 00:58:06 UTC) #1
Vadim Sh.
lgtm
3 years, 11 months ago (2017-01-24 01:06:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2653843003/20001
3 years, 11 months ago (2017-01-24 01:24:39 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-24 01:31:41 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/luci-go/commit/bb6d936a5d171c9ab1c1d3240c7c65eda935bebb

Powered by Google App Engine
This is Rietveld 408576698