Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1675)

Issue 2653833002: Fix an issue that download may missing MIME type if it failed ealier (Closed)

Created:
3 years, 11 months ago by qinmin
Modified:
3 years, 10 months ago
CC:
asanka, chromium-reviews, darin-cc_chromium.org, jam
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix an issue that download may missing MIME type if it failed ealier If a download fails before response is started, it will not have MIME type set. Later when resuming the download, Chrome should reset the MIME type when it becomes available. BUG=683084 Review-Url: https://codereview.chromium.org/2653833002 Cr-Commit-Position: refs/heads/master@{#446756} Committed: https://chromium.googlesource.com/chromium/src/+/521884b60a3ecb3b6ca5081b1e36244c2877e279

Patch Set 1 #

Patch Set 2 : fix DCHECK #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -0 lines) Patch
M content/browser/download/download_item_impl.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/download/download_item_impl_unittest.cc View 1 4 chunks +59 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
qinmin
PTAL
3 years, 11 months ago (2017-01-24 00:26:13 UTC) #2
David Trainor- moved to gerrit
lgtm!
3 years, 11 months ago (2017-01-24 16:59:44 UTC) #3
asanka
lgtm
3 years, 10 months ago (2017-01-27 01:42:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2653833002/1
3 years, 10 months ago (2017-01-27 07:03:32 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/311133)
3 years, 10 months ago (2017-01-27 07:26:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2653833002/20001
3 years, 10 months ago (2017-01-27 19:26:54 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-01-27 20:41:37 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/521884b60a3ecb3b6ca5081b1e36...

Powered by Google App Engine
This is Rietveld 408576698