Do not restart Chrome to apply user flags with stub session manager

Do not restart Chrome to apply user flags with stub session manager

This prevents restarting Chrome to apply per-user flags when not
running on Chrome OS - since Chrome OS session manager, which
initiates browser restart, does not run on desktop build of
Chrome OS, browser restart to apply user flags will not work.
All that would happen is browser shutdown.

Instead uf using SysInfo::IsRunningOnChromeOS directly, add
information about whether session manager supports restart to
session manager client - this will enable us to enable restart
behaviour in tests when needed, e.g. for tests that test browser
restart flow.

BUG=684796
Review-Url: https://codereview.chromium.org/2653823004
Cr-Commit-Position: refs/heads/master@{#446088}
Committed: https://chromium.googlesource.com/chromium/src/+/827ca1c2f792da3147275ea3c3ad0134f708d59f

[tbarzic, 2017-01-24 22:23:08]

The CQ bit was checked by tbarzic@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-24 22:24:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tbarzic, 2017-01-24 22:37:19]

The CQ bit was checked by tbarzic@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-24 22:38:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 23:11:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 23:11:50]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tbarzic, 2017-01-25 00:35:23]

The CQ bit was checked by tbarzic@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-25 00:36:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 01:27:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-25 01:27:51]

Dry run: This issue passed the CQ dry run.

[tbarzic, 2017-01-25 02:47:17]

tbarzic@chromium.org changed reviewers:
+ xiyuan@chromium.org

[xiyuan, 2017-01-25 19:26:48]

lgtm

[tbarzic, 2017-01-25 19:31:16]

The CQ bit was checked by tbarzic@chromium.org

[commit-bot: I haz the power, 2017-01-25 19:32:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 19:38:14]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1485372676552400,
"parent_rev": "6a19de6794f474515099b0e54c1d7000b832ea64", "commit_rev":
"827ca1c2f792da3147275ea3c3ad0134f708d59f"}

[commit-bot: I haz the power, 2017-01-25 19:38:44]

Description was changed from

==========
Do not restart Chrome to apply user flags with stub session manager

This prevents restarting Chrome to apply per-user flags when not
running on Chrome OS - since Chrome OS session manager, which
initiates browser restart, does not run on desktop build of
Chrome OS, browser restart to apply user flags will not work.
All that would happen is browser shutdown.

Instead uf using SysInfo::IsRunningOnChromeOS directly, add
information about whether session manager supports restart to
session manager client - this will enable us to enable restart
behaviour in tests when needed, e.g. for tests that test browser
restart flow.

BUG=684796
==========

to

==========
Do not restart Chrome to apply user flags with stub session manager

This prevents restarting Chrome to apply per-user flags when not
running on Chrome OS - since Chrome OS session manager, which
initiates browser restart, does not run on desktop build of
Chrome OS, browser restart to apply user flags will not work.
All that would happen is browser shutdown.

Instead uf using SysInfo::IsRunningOnChromeOS directly, add
information about whether session manager supports restart to
session manager client - this will enable us to enable restart
behaviour in tests when needed, e.g. for tests that test browser
restart flow.

BUG=684796

Review-Url: https://codereview.chromium.org/2653823004
Cr-Commit-Position: refs/heads/master@{#446088}
Committed:
https://chromium.googlesource.com/chromium/src/+/827ca1c2f792da3147275ea3c3ad...
==========

[commit-bot: I haz the power, 2017-01-25 19:38:46]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/827ca1c2f792da3147275ea3c3ad...