Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 2653783003: Fix front-end host creation upon navigation (Closed)

Created:
3 years, 11 months ago by caseq
Modified:
3 years, 11 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Fix front-end host creation upon navigation - when navigating, add host bindings to the pending frame rather than old frame; - force renderer swap if front-end URL is invalid; - move front-end URL validation to DevToolsUIBindingds This also re-lands https://codereview.chromium.org/2607833002 BUG=662859, 678035 Review-Url: https://codereview.chromium.org/2620153002 Cr-Commit-Position: refs/heads/master@{#442781} (cherry picked from commit c2db881506f5709433a5bf6ed981b1bc0c860598) Review-Url: https://codereview.chromium.org/2653783003 . Cr-Commit-Position: refs/branch-heads/2924@{#853} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} Committed: https://chromium.googlesource.com/chromium/src/+/d6f1c251f409263302a2df863df61314418dc4b2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+212 lines, -272 lines) Patch
M chrome/browser/devtools/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/devtools/devtools_ui_bindings.h View 3 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/devtools/devtools_ui_bindings.cc View 12 chunks +169 lines, -16 lines 0 comments Download
A + chrome/browser/devtools/devtools_ui_bindings_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/devtools/devtools_window.cc View 1 chunk +1 line, -1 line 0 comments Download
A chrome/browser/devtools/url_constants.h View 1 chunk +12 lines, -0 lines 0 comments Download
A chrome/browser/devtools/url_constants.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/devtools_ui.h View 2 chunks +1 line, -5 lines 0 comments Download
M chrome/browser/ui/webui/devtools_ui.cc View 5 chunks +2 lines, -140 lines 0 comments Download
D chrome/browser/ui/webui/devtools_ui_unittest.cc View 1 chunk +0 lines, -102 lines 0 comments Download
M chrome/test/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
caseq
3 years, 11 months ago (2017-01-24 03:22:51 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d6f1c251f409263302a2df863df61314418dc4b2.

Powered by Google App Engine
This is Rietveld 408576698