Make FontFaceCache::version return unique number across all instances

Make FontFaceCache::version return unique number across all instances

The global FallbackListShapeCache may contain entries created in
multiple documents that have different @font-face rules. Those entries
are versioned by FontFaceCache version, but entries from different
FontFaceCache instances can have same version number.

This patch makes sure that ShapeCache is invalidated when cached data is
created within the context of different FontFaceCache instance.

BUG=682999
Review-Url: https://codereview.chromium.org/2653773006
Cr-Commit-Position: refs/heads/master@{#445744}
Committed: https://chromium.googlesource.com/chromium/src/+/f2bb61c5104755025adb0f1c5327de420311d32e

[Kunihiko Sakamoto, 2017-01-24 08:26:56]

Description was changed from

==========
WIP
==========

to

==========
Make FontFaceCache::version return unique number across all instances

The global FallbackListShapeCache may contain entries created in
multiple documents that have different @font-face rules. Those entries
are versioned by FontFaceCache version, but entries from different
FontFaceCache instances can have same version number.

This patch makes sure that ShapeCache is invalidated when cached data is
created within the context of different FontFaceCache instance.

BUG=682999
==========

[Kunihiko Sakamoto, 2017-01-24 08:28:06]

The CQ bit was checked by ksakamoto@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-24 08:28:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Kunihiko Sakamoto, 2017-01-24 09:36:07]

ksakamoto@chromium.org changed reviewers:
+ eae@chromium.org

[commit-bot: I haz the power, 2017-01-24 09:53:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 09:53:06]

Dry run: This issue passed the CQ dry run.

[drott, 2017-01-24 12:16:17]

drott@chromium.org changed reviewers:
+ drott@chromium.org

[drott, 2017-01-24 12:16:21]

LGTM, great! Thanks for figuring this out and fixing this, I also like the
compact test case.

https://codereview.chromium.org/2653773006/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/FontFaceCache.cpp (right):

https://codereview.chromium.org/2653773006/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/FontFaceCache.cpp:131: m_version =
++s_version;
I assume multiple documents in the same renderer would all still be on the main
thread? We don't need anything like an atomic increment here?

[eae, 2017-01-24 16:49:29]

On 2017/01/24 12:16:21, drott wrote:
> LGTM, great! Thanks for figuring this out and fixing this, I also like the
> compact test case.
> 
>
https://codereview.chromium.org/2653773006/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/css/FontFaceCache.cpp (right):
> 
>
https://codereview.chromium.org/2653773006/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/css/FontFaceCache.cpp:131: m_version =
> ++s_version;
> I assume multiple documents in the same renderer would all still be on the
main
> thread? We don't need anything like an atomic increment here?

Blink is single threaded so this is fine.

LGTM

[eae, 2017-01-24 16:49:45]

The CQ bit was checked by eae@chromium.org

[commit-bot: I haz the power, 2017-01-24 16:49:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 16:55:38]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1485276585333590, "parent_rev":
"2617c4a136497244376e1bcf11aa356afb2a1e06", "commit_rev":
"f2bb61c5104755025adb0f1c5327de420311d32e"}

[commit-bot: I haz the power, 2017-01-24 16:56:15]

Description was changed from

==========
Make FontFaceCache::version return unique number across all instances

The global FallbackListShapeCache may contain entries created in
multiple documents that have different @font-face rules. Those entries
are versioned by FontFaceCache version, but entries from different
FontFaceCache instances can have same version number.

This patch makes sure that ShapeCache is invalidated when cached data is
created within the context of different FontFaceCache instance.

BUG=682999
==========

to

==========
Make FontFaceCache::version return unique number across all instances

The global FallbackListShapeCache may contain entries created in
multiple documents that have different @font-face rules. Those entries
are versioned by FontFaceCache version, but entries from different
FontFaceCache instances can have same version number.

This patch makes sure that ShapeCache is invalidated when cached data is
created within the context of different FontFaceCache instance.

BUG=682999

Review-Url: https://codereview.chromium.org/2653773006
Cr-Commit-Position: refs/heads/master@{#445744}
Committed:
https://chromium.googlesource.com/chromium/src/+/f2bb61c5104755025adb0f1c5327...
==========

[commit-bot: I haz the power, 2017-01-24 16:56:17]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f2bb61c5104755025adb0f1c5327...