[tests] Cleanup tests that use assertOptimized()/assertUnoptimized().

[tests] Cleanup tests that use assertOptimized()/assertUnoptimized().

This CL adds --crankshaft and --no-always-opt flags to the tests that use
assertOptimized() and assertUnoptimized() respectively.

This CL also adds presubmit checks that ensure that tests have the proper
flags set.

BUG=v8:5890
Review-Url: https://codereview.chromium.org/2653753007
Cr-Commit-Position: refs/heads/master@{#42709}
Committed: https://chromium.googlesource.com/v8/v8/+/a8a432701fee76967417be5b17e215ed961c9003

[Igor Sheludko, 2017-01-26 16:35:54]

Patchset #1 (id:1) has been deleted

[Igor Sheludko, 2017-01-26 16:36:13]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-26 16:36:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Igor Sheludko, 2017-01-26 16:36:30]

ishell@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[Igor Sheludko, 2017-01-26 16:36:31]

PTAL

[Michael Starzinger, 2017-01-26 16:51:46]

LGTM with comments.

https://codereview.chromium.org/2653753007/diff/20001/src/flag-definitions.h
File src/flag-definitions.h (right):

https://codereview.chromium.org/2653753007/diff/20001/src/flag-definitions.h#...
src/flag-definitions.h:491: DEFINE_IMPLICATION(turbo, crankshaft)
nit: Can you leave a "// TODO(turbofan): Rename --no-crankshaft to --no-optimize
eventually." here, otherwise the implication looks strange at first glance. :)

https://codereview.chromium.org/2653753007/diff/20001/test/cctest/heap/test-h...
File test/cctest/heap/test-heap.cc (right):

https://codereview.chromium.org/2653753007/diff/20001/test/cctest/heap/test-h...
test/cctest/heap/test-heap.cc:4184: if (!i::FLAG_crankshaft) return;
This looks fishy, the test _disabled_ optimization before. Now it only runs when
optimization is _enabled_.

[Igor Sheludko, 2017-01-26 17:01:40]

https://codereview.chromium.org/2653753007/diff/20001/src/flag-definitions.h
File src/flag-definitions.h (right):

https://codereview.chromium.org/2653753007/diff/20001/src/flag-definitions.h#...
src/flag-definitions.h:491: DEFINE_IMPLICATION(turbo, crankshaft)
On 2017/01/26 16:51:46, Michael Starzinger wrote:
> nit: Can you leave a "// TODO(turbofan): Rename --no-crankshaft to
--no-optimize
> eventually." here, otherwise the implication looks strange at first glance. :)

Done.

https://codereview.chromium.org/2653753007/diff/20001/test/cctest/heap/test-h...
File test/cctest/heap/test-heap.cc (right):

https://codereview.chromium.org/2653753007/diff/20001/test/cctest/heap/test-h...
test/cctest/heap/test-heap.cc:4184: if (!i::FLAG_crankshaft) return;
On 2017/01/26 16:51:46, Michael Starzinger wrote:
> This looks fishy, the test _disabled_ optimization before. Now it only runs
when
> optimization is _enabled_.

Done.

[Igor Sheludko, 2017-01-26 17:01:53]

The CQ bit was checked by ishell@chromium.org

[Igor Sheludko, 2017-01-26 17:01:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/2653753007/#ps40001
(title: "Addressing comments")

[commit-bot: I haz the power, 2017-01-26 17:01:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-26 17:39:10]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1485450113563730,
"parent_rev": "cc075f0e832c537f757e4d5458b9b849ba34f3d2", "commit_rev":
"a8a432701fee76967417be5b17e215ed961c9003"}

[commit-bot: I haz the power, 2017-01-26 17:39:14]

Description was changed from

==========
[tests] Cleanup tests that use assertOptimized()/assertUnoptimized().

This CL adds --crankshaft and --no-always-opt flags to the tests that use
assertOptimized() and assertUnoptimized() respectively.

This CL also adds presubmit checks that ensure that tests have the proper
flags set.

BUG=v8:5890
==========

to

==========
[tests] Cleanup tests that use assertOptimized()/assertUnoptimized().

This CL adds --crankshaft and --no-always-opt flags to the tests that use
assertOptimized() and assertUnoptimized() respectively.

This CL also adds presubmit checks that ensure that tests have the proper
flags set.

BUG=v8:5890

Review-Url: https://codereview.chromium.org/2653753007
Cr-Commit-Position: refs/heads/master@{#42709}
Committed:
https://chromium.googlesource.com/v8/v8/+/a8a432701fee76967417be5b17e215ed961...
==========

[commit-bot: I haz the power, 2017-01-26 17:39:16]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/a8a432701fee76967417be5b17e215ed961...