third_party/WebKit/Source/build/scripts/make_css_property_apis.py - Issue 2653733005: Added parseShorthand method from the parser to CSSPropertyAPI.h.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/build/scripts/make_css_property_apis.py

Issue 2653733005: Added parseShorthand method from the parser to CSSPropertyAPI.h. (Closed)

Patch Set: rebase Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/build/scripts/make_css_property_apis.py

diff --git a/third_party/WebKit/Source/build/scripts/make_css_property_apis.py b/third_party/WebKit/Source/build/scripts/make_css_property_apis.py

index 141daf2b70f98f8d57bcd60f79aee044984b35a5..d8900abcb8d255625dce3b17a50ece3d1fcb6947 100755

--- a/third_party/WebKit/Source/build/scripts/make_css_property_apis.py

+++ b/third_party/WebKit/Source/build/scripts/make_css_property_apis.py

@@ -26,7 +26,7 @@ class CSSPropertyAPIWriter(make_style_builder.StyleBuilderWriter):

def __init__(self, json5_file_path):

# Holds names of all valid methods in the API. When a new method is added

# to the API, it must also be added to this list.

- valid_methods = ["parseSingleValue"]

+ valid_methods = ["parseSingleValue", "parseShorthand"]

sashab 2017/01/31 22:58:14 Need to rebase this :)

aazzam 2017/02/01 00:30:05 rebased :)

super(CSSPropertyAPIWriter, self).__init__(json5_file_path)

self._outputs = {