Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Side by Side Diff: third_party/WebKit/Source/build/scripts/make_css_property_apis.py

Issue 2653733005: Added parseShorthand method from the parser to CSSPropertyAPI.h. (Closed)
Patch Set: rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright 2016 The Chromium Authors. All rights reserved. 2 # Copyright 2016 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 import sys 6 import sys
7 7
8 import json5_generator 8 import json5_generator
9 import template_expander 9 import template_expander
10 import make_style_builder 10 import make_style_builder
11 11
12 from collections import namedtuple, defaultdict 12 from collections import namedtuple, defaultdict
13 13
14 # Gets the classname for a given property. 14 # Gets the classname for a given property.
15 def get_classname(property): 15 def get_classname(property):
16 if property['api_class'] is True: 16 if property['api_class'] is True:
17 # This property had the generated_api_class flag set in CSSProperties.js on5. 17 # This property had the generated_api_class flag set in CSSProperties.js on5.
18 return 'CSSPropertyAPI' + property['upper_camel_name'] 18 return 'CSSPropertyAPI' + property['upper_camel_name']
19 # This property has a specified class name. 19 # This property has a specified class name.
20 assert isinstance(property['api_class'], str), \ 20 assert isinstance(property['api_class'], str), \
21 ("api_class value for " + property['api_class'] + " should be None, True or a string") 21 ("api_class value for " + property['api_class'] + " should be None, True or a string")
22 return property['api_class'] 22 return property['api_class']
23 23
24 24
25 class CSSPropertyAPIWriter(make_style_builder.StyleBuilderWriter): 25 class CSSPropertyAPIWriter(make_style_builder.StyleBuilderWriter):
26 def __init__(self, json5_file_path): 26 def __init__(self, json5_file_path):
27 # Holds names of all valid methods in the API. When a new method is adde d 27 # Holds names of all valid methods in the API. When a new method is adde d
28 # to the API, it must also be added to this list. 28 # to the API, it must also be added to this list.
29 valid_methods = ["parseSingleValue"] 29 valid_methods = ["parseSingleValue", "parseShorthand"]
sashab 2017/01/31 22:58:14 Need to rebase this :)
aazzam 2017/02/01 00:30:05 rebased :)
30 30
31 super(CSSPropertyAPIWriter, self).__init__(json5_file_path) 31 super(CSSPropertyAPIWriter, self).__init__(json5_file_path)
32 self._outputs = { 32 self._outputs = {
33 'CSSPropertyDescriptor.cpp': self.generate_property_descriptor_cpp, 33 'CSSPropertyDescriptor.cpp': self.generate_property_descriptor_cpp,
34 } 34 }
35 35
36 # Temporary map of API classname to list of propertyIDs that the API cla ss is for. 36 # Temporary map of API classname to list of propertyIDs that the API cla ss is for.
37 properties_for_class = defaultdict(list) 37 properties_for_class = defaultdict(list)
38 for property in self._properties.values(): 38 for property in self._properties.values():
39 if property['api_class'] is None: 39 if property['api_class'] is None:
(...skipping 28 matching lines...) Expand all
68 @template_expander.use_jinja('CSSPropertyAPIFiles.h.tmpl') 68 @template_expander.use_jinja('CSSPropertyAPIFiles.h.tmpl')
69 def generate_property_api_h(): 69 def generate_property_api_h():
70 return { 70 return {
71 'api_classname': api_classname, 71 'api_classname': api_classname,
72 'implemented_functions': implemented_functions, 72 'implemented_functions': implemented_functions,
73 } 73 }
74 return generate_property_api_h 74 return generate_property_api_h
75 75
76 if __name__ == '__main__': 76 if __name__ == '__main__':
77 json5_generator.Maker(CSSPropertyAPIWriter).main() 77 json5_generator.Maker(CSSPropertyAPIWriter).main()
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698