Android: Re-order deferred async task UMA record

Android: Re-order deferred async task UMA record

Ensure that when the UMA record for duration is written the entire async
task is done.

BUG=683944
Review-Url: https://codereview.chromium.org/2653733002
Cr-Commit-Position: refs/heads/master@{#445789}
Committed: https://chromium.googlesource.com/chromium/src/+/467d339230d5db21352a3568e906ab96818062d5

[Peter Wen, 2017-01-23 20:34:59]

The CQ bit was checked by wnwen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-23 20:35:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Peter Wen, 2017-01-23 20:36:17]

wnwen@chromium.org changed reviewers:
+ mariakhomenko@chromium.org

[Peter Wen, 2017-01-23 20:36:18]

Hi Maria,

I moved UMA recording into onPostExecute as a task is waiting to be done there
too. Crash uploading is more essential than WebappRegistry, so I've swapped
those two.

Thanks, hopefully this gives more clear numbers (possibly lower completion rate,
but more accurate).

Peter

[Maria, 2017-01-23 20:46:11]

https://codereview.chromium.org/2653733002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/DeferredStartupHandler.java
(right):

https://codereview.chromium.org/2653733002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/DeferredStartupHandler.java:298:
"UMA.Debug.EnableCrashUpload.DeferredStartUpDurationAsync",
I think you should rename this so that we can tell the data apart between old
versions and new versions of the code since it now measures a different
quantity.

[commit-bot: I haz the power, 2017-01-23 21:12:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-23 21:12:56]

Dry run: This issue passed the CQ dry run.

[Peter Wen, 2017-01-23 21:54:42]

In a separate CL I'll add more instrumentation as you mentioned in the bug.

https://codereview.chromium.org/2653733002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/DeferredStartupHandler.java
(right):

https://codereview.chromium.org/2653733002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/DeferredStartupHandler.java:298:
"UMA.Debug.EnableCrashUpload.DeferredStartUpDurationAsync",
On 2017/01/23 20:46:10, Maria wrote:
> I think you should rename this so that we can tell the data apart between old
> versions and new versions of the code since it now measures a different
> quantity.

Done.

[Maria, 2017-01-24 17:39:29]

lgtm

[Peter Wen, 2017-01-24 18:22:07]

The CQ bit was checked by wnwen@chromium.org to run a CQ dry run

[Peter Wen, 2017-01-24 18:22:21]

wnwen@chromium.org changed reviewers:
+ asvitkine@chromium.org

[Peter Wen, 2017-01-24 18:22:22]

+asvitkine@ for histogram OWNERS.

[commit-bot: I haz the power, 2017-01-24 18:22:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Alexei Svitkine (slow), 2017-01-24 18:28:26]

lgtm

[commit-bot: I haz the power, 2017-01-24 19:47:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 19:47:45]

Dry run: This issue passed the CQ dry run.

[Peter Wen, 2017-01-24 19:56:17]

The CQ bit was checked by wnwen@chromium.org

[commit-bot: I haz the power, 2017-01-24 19:56:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 20:03:56]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485287777072840,
"parent_rev": "a36717f4c79513664b45ba0248ebd731cf6e3e0c", "commit_rev":
"467d339230d5db21352a3568e906ab96818062d5"}

[commit-bot: I haz the power, 2017-01-24 20:04:30]

Description was changed from

==========
Android: Re-order deferred async task UMA record

Ensure that when the UMA record for duration is written the entire async
task is done.

BUG=683944
==========

to

==========
Android: Re-order deferred async task UMA record

Ensure that when the UMA record for duration is written the entire async
task is done.

BUG=683944

Review-Url: https://codereview.chromium.org/2653733002
Cr-Commit-Position: refs/heads/master@{#445789}
Committed:
https://chromium.googlesource.com/chromium/src/+/467d339230d5db21352a3568e906...
==========

[commit-bot: I haz the power, 2017-01-24 20:04:31]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/467d339230d5db21352a3568e906...