Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2653693003: [cleanup] Refactor builtins-generator.cc to use TF_BUILTIN macro (Closed)

Created:
3 years, 11 months ago by jgruber
Modified:
3 years, 11 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[cleanup] Refactor builtins-generator.cc to use TF_BUILTIN macro BUG= Review-Url: https://codereview.chromium.org/2653693003 Cr-Commit-Position: refs/heads/master@{#42645} Committed: https://chromium.googlesource.com/v8/v8/+/39b858754e0b6d9a75e5525e50e9bf378b6c9472

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -68 lines) Patch
M src/builtins/builtins-generator.cc View 1 chunk +58 lines, -68 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
jgruber
And another one, please take a look.
3 years, 11 months ago (2017-01-24 16:07:30 UTC) #6
Jakob Kummerow
Nice, LGTM.
3 years, 11 months ago (2017-01-24 17:10:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2653693003/1
3 years, 11 months ago (2017-01-25 07:29:05 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-25 07:36:31 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/39b858754e0b6d9a75e5525e50e9bf378b6...

Powered by Google App Engine
This is Rietveld 408576698