Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 2653673007: [Platform] Increase default stack size on Mac OS X to 1MB. (Closed)

Created:
3 years, 11 months ago by rmcilroy
Modified:
3 years, 11 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Platform] Increase default stack size on Mac OS X to 1MB. The default stack size of a background thread is 512KB on MacOSX. We default to 1MB stack checks when compiling JS code, so we need to increase this limit to enable compilation of JS code onto background threads. Corresponding Chromium CL is https://codereview.chromium.org/2640803002/ BUG=v8:5203 Review-Url: https://codereview.chromium.org/2653673007 Cr-Commit-Position: refs/heads/master@{#42650} Committed: https://chromium.googlesource.com/v8/v8/+/8bae36f963a20dad603819bd5901fcf90756d78a

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M src/base/platform/platform-posix.cc View 1 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
rmcilroy
Michi could you please take a look, thanks.
3 years, 11 months ago (2017-01-24 15:00:41 UTC) #4
Michael Starzinger
LGTM. https://codereview.chromium.org/2653673007/diff/1/src/base/platform/platform-posix.cc File src/base/platform/platform-posix.cc (right): https://codereview.chromium.org/2653673007/diff/1/src/base/platform/platform-posix.cc#newcode625 src/base/platform/platform-posix.cc:625: // Default on AIX is 512kB -- bump ...
3 years, 11 months ago (2017-01-25 09:26:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2653673007/20001
3 years, 11 months ago (2017-01-25 10:03:12 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/v8/v8/+/8bae36f963a20dad603819bd5901fcf90756d78a
3 years, 11 months ago (2017-01-25 10:35:18 UTC) #13
rmcilroy
3 years, 11 months ago (2017-01-25 11:05:03 UTC) #14
Message was sent while issue was closed.
https://codereview.chromium.org/2653673007/diff/1/src/base/platform/platform-...
File src/base/platform/platform-posix.cc (right):

https://codereview.chromium.org/2653673007/diff/1/src/base/platform/platform-...
src/base/platform/platform-posix.cc:625: // Default on AIX is 512kB -- bump up
to 1MB
On 2017/01/25 09:26:22, Michael Starzinger wrote:
> nit: Comment is off, s/AIX/MacOS/ here.

Done.

Powered by Google App Engine
This is Rietveld 408576698