Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Issue 2653673002: PPC/s390: Split some SharedFunctionInfo's compiler hints off into debugger hints. (Closed)

Created:
3 years, 11 months ago by JaideepBajwa
Modified:
3 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC/s390: Split some SharedFunctionInfo's compiler hints off into debugger hints. Port 3a9152ece721903d3b82e60e8d95f51341183f28 Original Commit Message: We are planning to add a few more debugger related bits, and are running out of compiler hints bits. The new bit field is going to be part of the debug info struct. If the debug info is not available, we store the bit field in its place on the shared function info. R=yangguo@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Review-Url: https://codereview.chromium.org/2653673002 Cr-Commit-Position: refs/heads/master@{#42608} Committed: https://chromium.googlesource.com/v8/v8/+/d80781442f490e39641fcef14c65082565a4d3c5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/builtins/ppc/builtins-ppc.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/builtins/s390/builtins-s390.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
JaideepBajwa
ptal
3 years, 11 months ago (2017-01-23 16:08:44 UTC) #1
john.yan
lgtm
3 years, 11 months ago (2017-01-23 17:35:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2653673002/1
3 years, 11 months ago (2017-01-23 17:36:22 UTC) #4
commit-bot: I haz the power
3 years, 11 months ago (2017-01-23 17:58:22 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/d80781442f490e39641fcef14c65082565a...

Powered by Google App Engine
This is Rietveld 408576698