Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(625)

Issue 2653623002: [crankshaft] Fix string addition to check for max length of cons string. (Closed)

Created:
3 years, 11 months ago by Jarin
Modified:
3 years, 11 months ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[crankshaft] Fix string addition to check for max length of cons string. BUG=chromium:678917 Review-Url: https://codereview.chromium.org/2653623002 Cr-Commit-Position: refs/heads/master@{#42621} Committed: https://chromium.googlesource.com/v8/v8/+/dd310b434181902a8e8a93890dd634a2e8cfc825

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -0 lines) Patch
M src/crankshaft/hydrogen.cc View 1 chunk +3 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-678917.js View 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Jarin
Could you take a look, please?
3 years, 11 months ago (2017-01-23 13:59:26 UTC) #2
Igor Sheludko
lgtm
3 years, 11 months ago (2017-01-24 09:12:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2653623002/1
3 years, 11 months ago (2017-01-24 09:13:04 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-24 09:36:02 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/dd310b434181902a8e8a93890dd634a2e8c...

Powered by Google App Engine
This is Rietveld 408576698