Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2653603002: MIPS[64]: Prevent multiple instances of tests that require a lot of memory (Closed)

Created:
3 years, 11 months ago by ivica.bogosavljevic
Modified:
3 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS[64]: Prevent multiple instances of tests that require a lot of memory Some tests require a lot of memory and they fail on buildbots if they run in parallel with other tests of the same kind. We try to limit this by disabling multiple vairants of the same tests, assuming this would stop the failures in most of the cases. BUG= Review-Url: https://codereview.chromium.org/2653603002 Cr-Commit-Position: refs/heads/master@{#42741} Committed: https://chromium.googlesource.com/v8/v8/+/2f728bd9a046e33e91b234c2a6e60081172669ae

Patch Set 1 #

Total comments: 1

Patch Set 2 : Run disables tests on simulator #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M test/mjsunit/mjsunit.status View 1 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
ivica.bogosavljevic
PTAL
3 years, 11 months ago (2017-01-23 13:09:19 UTC) #2
jochen (gone - plz use gerrit)
I defer to machenbach
3 years, 11 months ago (2017-01-24 12:35:35 UTC) #3
Michael Achenbach
lgtm with comment. Please refer to issue v8:5861 in CL description. https://codereview.chromium.org/2653603002/diff/1/test/mjsunit/mjsunit.status File test/mjsunit/mjsunit.status (right): ...
3 years, 11 months ago (2017-01-24 14:01:19 UTC) #5
ivica.bogosavljevic
On 2017/01/24 14:01:19, Michael Achenbach wrote: > lgtm with comment. Please refer to issue v8:5861 ...
3 years, 11 months ago (2017-01-24 15:18:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2653603002/20001
3 years, 10 months ago (2017-01-27 14:14:04 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-01-27 14:16:05 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/2f728bd9a046e33e91b234c2a6e60081172...

Powered by Google App Engine
This is Rietveld 408576698