Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 2653493011: [PerfBenchmarks] Disable power.tough_ad_cases on Android (Closed)

Created:
3 years, 11 months ago by fmeawad
Modified:
3 years, 11 months ago
Reviewers:
eakuefner
CC:
charliea (OOO until 10-5), chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[PerfBenchmarks] Disable power.tough_ad_cases on Android BUG=683238 # CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq Review-Url: https://codereview.chromium.org/2653493011 Cr-Commit-Position: refs/heads/master@{#446030} Committed: https://chromium.googlesource.com/chromium/src/+/495d2cc61abb04bfdb66ad52c5ba48a4f1ffd7a4

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix a typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M tools/perf/benchmarks/power.py View 1 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 22 (13 generated)
fmeawad
PTAL
3 years, 11 months ago (2017-01-24 23:26:37 UTC) #3
eakuefner
lgtm https://codereview.chromium.org/2653493011/diff/1/tools/perf/benchmarks/power.py File tools/perf/benchmarks/power.py (right): https://codereview.chromium.org/2653493011/diff/1/tools/perf/benchmarks/power.py#newcode50 tools/perf/benchmarks/power.py:50: # This benchmark runs only on android by ...
3 years, 11 months ago (2017-01-25 00:11:33 UTC) #6
fmeawad
https://codereview.chromium.org/2653493011/diff/1/tools/perf/benchmarks/power.py File tools/perf/benchmarks/power.py (right): https://codereview.chromium.org/2653493011/diff/1/tools/perf/benchmarks/power.py#newcode50 tools/perf/benchmarks/power.py:50: # This benchmark runs only on android by it ...
3 years, 11 months ago (2017-01-25 00:29:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2653493011/20001
3 years, 11 months ago (2017-01-25 00:30:55 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_perf_cq on master.tryserver.chromium.perf (JOB_TIMED_OUT, no build URL) mac_retina_perf_cq on ...
3 years, 11 months ago (2017-01-25 02:34:06 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2653493011/20001
3 years, 11 months ago (2017-01-25 04:03:25 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_perf_cq on master.tryserver.chromium.perf (JOB_TIMED_OUT, no build URL) mac_retina_perf_cq on ...
3 years, 11 months ago (2017-01-25 06:04:29 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2653493011/20001
3 years, 11 months ago (2017-01-25 16:16:45 UTC) #19
commit-bot: I haz the power
3 years, 11 months ago (2017-01-25 16:24:13 UTC) #22
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/495d2cc61abb04bfdb66ad52c5ba...

Powered by Google App Engine
This is Rietveld 408576698