|
|
Chromium Code Reviews
Description[PerfBenchmarks] Disable power.tough_ad_cases on Android
BUG=683238
# CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq
Review-Url: https://codereview.chromium.org/2653493011
Cr-Commit-Position: refs/heads/master@{#446030}
Committed: https://chromium.googlesource.com/chromium/src/+/495d2cc61abb04bfdb66ad52c5ba48a4f1ffd7a4
Patch Set 1 #
Total comments: 2
Patch Set 2 : fix a typo #Messages
Total messages: 22 (13 generated)
Description was changed from ========== [PerfBenchmarks] Disable power.tough_ad_cases on Android BUG=683238 ========== to ========== [PerfBenchmarks] Disable power.tough_ad_cases on Android BUG=683238 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
fmeawad@chromium.org changed reviewers: + eakuefner@chromium.org
PTAL
The CQ bit was checked by fmeawad@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm https://codereview.chromium.org/2653493011/diff/1/tools/perf/benchmarks/power.py File tools/perf/benchmarks/power.py (right): https://codereview.chromium.org/2653493011/diff/1/tools/perf/benchmarks/power... tools/perf/benchmarks/power.py:50: # This benchmark runs only on android by it is disabled on android as well nit: s/by/but/ ?
https://codereview.chromium.org/2653493011/diff/1/tools/perf/benchmarks/power.py File tools/perf/benchmarks/power.py (right): https://codereview.chromium.org/2653493011/diff/1/tools/perf/benchmarks/power... tools/perf/benchmarks/power.py:50: # This benchmark runs only on android by it is disabled on android as well On 2017/01/25 00:11:33, eakuefner wrote: > nit: s/by/but/ ? Done.
The CQ bit was checked by fmeawad@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from eakuefner@chromium.org Link to the patchset: https://codereview.chromium.org/2653493011/#ps20001 (title: "fix a typo")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_perf_cq on master.tryserver.chromium.perf (JOB_TIMED_OUT, no build URL) mac_retina_perf_cq on master.tryserver.chromium.perf (JOB_TIMED_OUT, no build URL) winx64_10_perf_cq on master.tryserver.chromium.perf (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by fmeawad@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_perf_cq on master.tryserver.chromium.perf (JOB_TIMED_OUT, no build URL) mac_retina_perf_cq on master.tryserver.chromium.perf (JOB_TIMED_OUT, no build URL) winx64_10_perf_cq on master.tryserver.chromium.perf (JOB_TIMED_OUT, no build URL)
Description was changed from ========== [PerfBenchmarks] Disable power.tough_ad_cases on Android BUG=683238 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== [PerfBenchmarks] Disable power.tough_ad_cases on Android BUG=683238 # CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
The CQ bit was checked by fmeawad@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485360980098260,
"parent_rev": "64a7ecf6db8f4f070152509d450417f08866ed3e", "commit_rev":
"495d2cc61abb04bfdb66ad52c5ba48a4f1ffd7a4"}
Message was sent while issue was closed.
Description was changed from ========== [PerfBenchmarks] Disable power.tough_ad_cases on Android BUG=683238 # CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== [PerfBenchmarks] Disable power.tough_ad_cases on Android BUG=683238 # CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq Review-Url: https://codereview.chromium.org/2653493011 Cr-Commit-Position: refs/heads/master@{#446030} Committed: https://chromium.googlesource.com/chromium/src/+/495d2cc61abb04bfdb66ad52c5ba... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/495d2cc61abb04bfdb66ad52c5ba... |
