Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: content/common/service_worker/service_worker_provider_interfaces.mojom

Issue 2653493009: Add two interfaces for ServiceWorkerProviderContext/ProviderHost (Closed)
Patch Set: Rebased Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/service_worker/service_worker_provider_interfaces.mojom
diff --git a/content/common/service_worker/service_worker_provider_interfaces.mojom b/content/common/service_worker/service_worker_provider_interfaces.mojom
new file mode 100644
index 0000000000000000000000000000000000000000..3ba61e046c543fec0966d8270e49b2bb7cd50182
--- /dev/null
+++ b/content/common/service_worker/service_worker_provider_interfaces.mojom
@@ -0,0 +1,29 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+module content.mojom;
+
+// mojom::ServiceWorkerProviderHost is a browser-side
+// interface bound to content::ServiceWorkerProviderHost. The renderer uses this
kinuko 2017/05/23 12:57:20 Hmm, I can see what this comment tries to clarify
falken 2017/05/29 08:47:28 Fair enough, yea. Let's remove the mentions of the
shimazu 2017/05/30 03:50:07 Thanks for your comments. It sounds good to separa
+// interface to request the browser to do operations involving service worker
+// registrations.
+// A content::ServiceWorkerProviderHost bound with this interface will be destroyed when
+// the connection is disconnected.
kinuko 2017/05/23 12:57:20 Again this seems to be implementation detail which
falken 2017/05/29 08:47:28 Sure let's move this documentation to content::Ser
shimazu 2017/05/30 03:50:07 Done.
+interface ServiceWorkerProviderHost {
+ // TODO(shimazu): implement them.
+ // register() => ();
+ // getRegistation() => ();
+ // getRegistrations() => ();
+ // getRegistrationForReady() => ();
+};
+
+// mojom::ServiceWorkerProvider is a renderer-side interface bound to
+// content::ServiceWorkerProviderContext.
falken 2017/05/29 08:47:28 By the same logic I guess we should just call this
shimazu 2017/05/30 03:50:07 Done.
+interface ServiceWorkerProvider {
+ // TODO(shimazu): implement them.
+ // associateRegistration();
+ // disassociateRegistration();
+ // setControllerServiceWorker();
+ // messageToDocument();
+};

Powered by Google App Engine
This is Rietveld 408576698