Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Side by Side Diff: content/common/service_worker/service_worker_provider_interfaces.mojom

Issue 2653493009: Add two interfaces for ServiceWorkerProviderContext/ProviderHost (Closed)
Patch Set: Rebased Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 module content.mojom;
6
7 // mojom::ServiceWorkerProviderHost is a browser-side
8 // interface bound to content::ServiceWorkerProviderHost. The renderer uses this
kinuko 2017/05/23 12:57:20 Hmm, I can see what this comment tries to clarify
falken 2017/05/29 08:47:28 Fair enough, yea. Let's remove the mentions of the
shimazu 2017/05/30 03:50:07 Thanks for your comments. It sounds good to separa
9 // interface to request the browser to do operations involving service worker
10 // registrations.
11 // A content::ServiceWorkerProviderHost bound with this interface will be destro yed when
12 // the connection is disconnected.
kinuko 2017/05/23 12:57:20 Again this seems to be implementation detail which
falken 2017/05/29 08:47:28 Sure let's move this documentation to content::Ser
shimazu 2017/05/30 03:50:07 Done.
13 interface ServiceWorkerProviderHost {
14 // TODO(shimazu): implement them.
15 // register() => ();
16 // getRegistation() => ();
17 // getRegistrations() => ();
18 // getRegistrationForReady() => ();
19 };
20
21 // mojom::ServiceWorkerProvider is a renderer-side interface bound to
22 // content::ServiceWorkerProviderContext.
falken 2017/05/29 08:47:28 By the same logic I guess we should just call this
shimazu 2017/05/30 03:50:07 Done.
23 interface ServiceWorkerProvider {
24 // TODO(shimazu): implement them.
25 // associateRegistration();
26 // disassociateRegistration();
27 // setControllerServiceWorker();
28 // messageToDocument();
29 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698