content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc - Issue 2653493009: Add two interfaces for ServiceWorkerProviderContext/ProviderHost

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc

Issue 2653493009: Add two interfaces for ServiceWorkerProviderContext/ProviderHost (Closed)

Patch Set: Rebased Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/service_worker/service_worker_provider_host.h ('K') | « content/browser/service_worker/service_worker_version_unittest.cc ('k') | content/child/service_worker/service_worker_dispatcher_unittest.cc » ('j') | content/common/service_worker/service_worker_provider_interfaces.mojom » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc

diff --git a/content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc b/content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc

index 6940bdc7a8a6d072b3cc8a005c598ea6d0670470..544ba639ff0284c33b12d1b1f4afb06f48a8401c 100644

--- a/content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc

+++ b/content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc

@@ -293,7 +293,7 @@ class ServiceWorkerWriteToCacheJobTest : public testing::Test {

std::unique_ptr<ServiceWorkerProviderHost> host =

CreateProviderHostForServiceWorkerContext(

process_id, provider_id, true /* is_parent_frame_secure */,

- context()->AsWeakPtr());

+ context()->AsWeakPtr(), &remote_endpoint_);

base::WeakPtr<ServiceWorkerProviderHost> provider_host = host->AsWeakPtr();

context()->AddProviderHost(std::move(host));

provider_host->running_hosted_version_ = version;

@@ -441,6 +441,7 @@ class ServiceWorkerWriteToCacheJobTest : public testing::Test {

storage::BlobStorageContext blob_storage_context_;

content::MockResourceContext resource_context_;

+ ServiceWorkerRemoteProviderEndpoint remote_endpoint_;

net::TestDelegate url_request_delegate_;

int next_provider_id_ = 1;