Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 2653493007: Change the flow for UI mirroring tests to start mirroing first then play the video. Replace WaitUnt… (Closed)

Created:
3 years, 11 months ago by cliffordcheng1
Modified:
3 years, 11 months ago
Reviewers:
imcheng, Lei Lei
CC:
chromium-reviews, media-router+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change the flow for UI mirroring tests to start mirroing first then play the video. Replace WaitUntilRouteCreated() with some other checks to improve stability. BUG=678315 Review-Url: https://codereview.chromium.org/2653493007 Cr-Commit-Position: refs/heads/master@{#446272} Committed: https://chromium.googlesource.com/chromium/src/+/e66e46481c5417326acbed50046d24d43e9ba1b4

Patch Set 1 #

Total comments: 4

Patch Set 2 : Change the flow for UI mirroring tests to start mirroing first then play the video. Replace WaitUnt… #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -15 lines) Patch
M chrome/test/media_router/media_router_e2e_ui_browsertest.cc View 1 1 chunk +18 lines, -15 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
cliffordcheng1
3 years, 11 months ago (2017-01-23 22:49:24 UTC) #2
Lei Lei
lgtm
3 years, 11 months ago (2017-01-24 19:22:15 UTC) #3
imcheng
lgtm % comments https://codereview.chromium.org/2653493007/diff/1/chrome/test/media_router/media_router_e2e_ui_browsertest.cc File chrome/test/media_router/media_router_e2e_ui_browsertest.cc (right): https://codereview.chromium.org/2653493007/diff/1/chrome/test/media_router/media_router_e2e_ui_browsertest.cc#newcode19 chrome/test/media_router/media_router_e2e_ui_browsertest.cc:19: // Wait for 2s to make ...
3 years, 11 months ago (2017-01-24 20:03:31 UTC) #4
cliffordcheng1
https://codereview.chromium.org/2653493007/diff/1/chrome/test/media_router/media_router_e2e_ui_browsertest.cc File chrome/test/media_router/media_router_e2e_ui_browsertest.cc (right): https://codereview.chromium.org/2653493007/diff/1/chrome/test/media_router/media_router_e2e_ui_browsertest.cc#newcode19 chrome/test/media_router/media_router_e2e_ui_browsertest.cc:19: // Wait for 2s to make sure the dialog ...
3 years, 11 months ago (2017-01-24 23:13:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2653493007/20001
3 years, 11 months ago (2017-01-26 03:28:02 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/350817)
3 years, 11 months ago (2017-01-26 07:29:43 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2653493007/20001
3 years, 11 months ago (2017-01-26 07:53:40 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-26 07:58:52 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e66e46481c5417326acbed50046d...

Powered by Google App Engine
This is Rietveld 408576698