Change the flow for UI mirroring tests to start mirroing first then play the video. Replace WaitUnt…

Change the flow for UI mirroring tests to start mirroing first then play the video. Replace WaitUntilRouteCreated() with some other checks to improve stability.

BUG=678315
Review-Url: https://codereview.chromium.org/2653493007
Cr-Commit-Position: refs/heads/master@{#446272}
Committed: https://chromium.googlesource.com/chromium/src/+/e66e46481c5417326acbed50046d24d43e9ba1b4

[cliffordcheng1, 2017-01-23 22:49:24]

cliffordcheng@chromium.org changed reviewers:
+ imcheng@chromium.org, leilei@chromium.org

[Lei Lei, 2017-01-24 19:22:15]

lgtm

[imcheng, 2017-01-24 20:03:31]

lgtm % comments

https://codereview.chromium.org/2653493007/diff/1/chrome/test/media_router/me...
File chrome/test/media_router/media_router_e2e_ui_browsertest.cc (right):

https://codereview.chromium.org/2653493007/diff/1/chrome/test/media_router/me...
chrome/test/media_router/media_router_e2e_ui_browsertest.cc:19: // Wait for 2s
to make sure the dialog finishes rendering.
nit: blank line before comments here and below.

https://codereview.chromium.org/2653493007/diff/1/chrome/test/media_router/me...
chrome/test/media_router/media_router_e2e_ui_browsertest.cc:20:
Wait(base::TimeDelta::FromSeconds(2));
Can you use WaitUntilDialogFullyLoaded() here and below? Prefer explicit
conditional checks vs. waiting for a fixed amount of time.

[cliffordcheng1, 2017-01-24 23:13:18]

https://codereview.chromium.org/2653493007/diff/1/chrome/test/media_router/me...
File chrome/test/media_router/media_router_e2e_ui_browsertest.cc (right):

https://codereview.chromium.org/2653493007/diff/1/chrome/test/media_router/me...
chrome/test/media_router/media_router_e2e_ui_browsertest.cc:19: // Wait for 2s
to make sure the dialog finishes rendering.
On 2017/01/24 20:03:31, imcheng wrote:
> nit: blank line before comments here and below.

Done.

https://codereview.chromium.org/2653493007/diff/1/chrome/test/media_router/me...
chrome/test/media_router/media_router_e2e_ui_browsertest.cc:20:
Wait(base::TimeDelta::FromSeconds(2));
On 2017/01/24 20:03:31, imcheng wrote:
> Can you use WaitUntilDialogFullyLoaded() here and below? Prefer explicit
> conditional checks vs. waiting for a fixed amount of time.

Done.

[cliffordcheng1, 2017-01-26 03:27:28]

The CQ bit was checked by cliffordcheng@chromium.org

[cliffordcheng1, 2017-01-26 03:27:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
imcheng@chromium.org, leilei@chromium.org
Link to the patchset: https://codereview.chromium.org/2653493007/#ps20001
(title: "Change the flow for UI mirroring tests to start mirroing first then
play the video. Replace WaitUnt…")

[commit-bot: I haz the power, 2017-01-26 03:28:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-26 07:29:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-26 07:29:43]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[cliffordcheng1, 2017-01-26 07:53:28]

The CQ bit was checked by cliffordcheng@chromium.org

[commit-bot: I haz the power, 2017-01-26 07:53:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-26 07:58:22]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485417208732020,
"parent_rev": "59473b9e2c27131e748807e5390d33f20fcacc97", "commit_rev":
"e66e46481c5417326acbed50046d24d43e9ba1b4"}

[commit-bot: I haz the power, 2017-01-26 07:58:51]

Description was changed from

==========
Change the flow for UI mirroring tests to start mirroing first then play the
video. Replace WaitUntilRouteCreated() with some other checks to improve
stability.

BUG=678315
==========

to

==========
Change the flow for UI mirroring tests to start mirroing first then play the
video. Replace WaitUntilRouteCreated() with some other checks to improve
stability.

BUG=678315

Review-Url: https://codereview.chromium.org/2653493007
Cr-Commit-Position: refs/heads/master@{#446272}
Committed:
https://chromium.googlesource.com/chromium/src/+/e66e46481c5417326acbed50046d...
==========

[commit-bot: I haz the power, 2017-01-26 07:58:52]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e66e46481c5417326acbed50046d...