Allow building Chrome with local VC++ 2017 install

Allow building Chrome with local VC++ 2017 install

This updates the toolchain scripts enough so that it is possible to
build Chrome with VC++ 2017 if DEPOT_TOOLS_WIN_TOOLCHAIN=0 and
GYP_MSVS_VERSION=2017, followed by gclient runhooks.

There are still some local patches needed to make it work, and
treat_warnings_as_errors = false and is_component_build = false in
args.gn may be needed initially, but my local builds are working.

The toolchain code should be updated eventually to use COM to locate
the VC++ install location, instead of the hard-coded path which is being
used as a temporary measure in this change.

R=scottmg@chromium.org
BUG=683729
Review-Url: https://codereview.chromium.org/2653473002
Cr-Commit-Position: refs/heads/master@{#445329}
Committed: https://chromium.googlesource.com/chromium/src/+/adddab40528d1fb6dd94c0e4d2bc794ffccf194a

[brucedawson, 2017-01-22 21:29:26]

PTAL

[scottmg, 2017-01-22 23:43:35]

lgtm

https://codereview.chromium.org/2653473002/diff/1/build/vs_toolchain.py
File build/vs_toolchain.py (right):

https://codereview.chromium.org/2653473002/diff/1/build/vs_toolchain.py#newco...
build/vs_toolchain.py:146: # The VC++ 2017 install location needs to be located
using COM instead of
Muppets. I guess we can do a .ps that prints out the location or something.

https://codereview.chromium.org/2653473002/diff/1/build/vs_toolchain.py#newco...
build/vs_toolchain.py:172: if vs_version == '2013':
Probably time to delete all the 2013 stuff too I guess.

https://codereview.chromium.org/2653473002/diff/1/build/vs_toolchain.py#newco...
build/vs_toolchain.py:243: _CopyRuntime2015(target_dir, source_dir, '%s140' +
suffix, suffix)
Please rename this function.

[brucedawson, 2017-01-23 06:46:03]

https://codereview.chromium.org/2653473002/diff/1/build/vs_toolchain.py
File build/vs_toolchain.py (right):

https://codereview.chromium.org/2653473002/diff/1/build/vs_toolchain.py#newco...
build/vs_toolchain.py:146: # The VC++ 2017 install location needs to be located
using COM instead of
On 2017/01/22 23:43:35, scottmg wrote:
> Muppets. I guess we can do a .ps that prints out the location or something.

I assume we can do COM from Python, but I don't really know. Maybe the existing
(hardcoded plus environment variable override) will be good enough for as long
as we need it.

https://codereview.chromium.org/2653473002/diff/1/build/vs_toolchain.py#newco...
build/vs_toolchain.py:172: if vs_version == '2013':
On 2017/01/22 23:43:35, scottmg wrote:
> Probably time to delete all the 2013 stuff too I guess.

Yep. It good get messy, but now that we're getting hints about the next version
of VS it should be easier to know what to generalize and what to specialize.

https://codereview.chromium.org/2653473002/diff/1/build/vs_toolchain.py#newco...
build/vs_toolchain.py:243: _CopyRuntime2015(target_dir, source_dir, '%s140' +
suffix, suffix)
On 2017/01/22 23:43:35, scottmg wrote:
> Please rename this function.

Done.

[brucedawson, 2017-01-23 06:46:12]

The CQ bit was checked by brucedawson@chromium.org

[brucedawson, 2017-01-23 06:46:13]

The patchset sent to the CQ was uploaded after l-g-t-m from scottmg@chromium.org
Link to the patchset: https://codereview.chromium.org/2653473002/#ps20001
(title: "Rename _CopyRuntime2015 to _CopyUCRTRuntime")

[commit-bot: I haz the power, 2017-01-23 06:46:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-23 06:57:26]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485153972932550,
"parent_rev": "dcc5978539854826253e97b7c2e4be61a73a2153", "commit_rev":
"adddab40528d1fb6dd94c0e4d2bc794ffccf194a"}

[commit-bot: I haz the power, 2017-01-23 06:58:40]

Description was changed from

==========
Allow building Chrome with local VC++ 2017 install

This updates the toolchain scripts enough so that it is possible to
build Chrome with VC++ 2017 if DEPOT_TOOLS_WIN_TOOLCHAIN=0 and
GYP_MSVS_VERSION=2017, followed by gclient runhooks.

There are still some local patches needed to make it work, and
treat_warnings_as_errors = false and is_component_build = false in
args.gn may be needed initially, but my local builds are working.

The toolchain code should be updated eventually to use COM to locate
the VC++ install location, instead of the hard-coded path which is being
used as a temporary measure in this change.

R=scottmg@chromium.org
BUG=683729
==========

to

==========
Allow building Chrome with local VC++ 2017 install

This updates the toolchain scripts enough so that it is possible to
build Chrome with VC++ 2017 if DEPOT_TOOLS_WIN_TOOLCHAIN=0 and
GYP_MSVS_VERSION=2017, followed by gclient runhooks.

There are still some local patches needed to make it work, and
treat_warnings_as_errors = false and is_component_build = false in
args.gn may be needed initially, but my local builds are working.

The toolchain code should be updated eventually to use COM to locate
the VC++ install location, instead of the hard-coded path which is being
used as a temporary measure in this change.

R=scottmg@chromium.org
BUG=683729

Review-Url: https://codereview.chromium.org/2653473002
Cr-Commit-Position: refs/heads/master@{#445329}
Committed:
https://chromium.googlesource.com/chromium/src/+/adddab40528d1fb6dd94c0e4d2bc...
==========

[commit-bot: I haz the power, 2017-01-23 06:58:41]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/adddab40528d1fb6dd94c0e4d2bc...

[Sébastien Marchand, 2017-05-10 21:23:48]

sebmarchand@chromium.org changed reviewers:
+ sebmarchand@chromium.org

[Sébastien Marchand, 2017-05-10 21:23:49]

https://codereview.chromium.org/2653473002/diff/20001/build/vs_toolchain.py
File build/vs_toolchain.py (right):

https://codereview.chromium.org/2653473002/diff/20001/build/vs_toolchain.py#n...
build/vs_toolchain.py:177: return '150'
Is it true? The files in 4e8a360587a3c8ff3fa46aa9271e982bf3e948ec seems to be
using the 140 version number, any idea why?

[brucedawson, 2017-05-10 21:32:32]

https://codereview.chromium.org/2653473002/diff/20001/build/vs_toolchain.py
File build/vs_toolchain.py (right):

https://codereview.chromium.org/2653473002/diff/20001/build/vs_toolchain.py#n...
build/vs_toolchain.py:177: return '150'
On 2017/05/10 21:23:49, Sébastien Marchand wrote:
> Is it true? The files in 4e8a360587a3c8ff3fa46aa9271e982bf3e948ec seems to be
> using the 140 version number, any idea why?

I think VS 2017 uses 140, 141, and 150, depending on context. What specific
files are you referring to?

[Sébastien Marchand, 2017-05-11 14:46:58]

I was looking at pgort140.dll, but it looks like all the DLLs
in 4e8a360587a3c8ff3fa46aa9271e982bf3e948ec use ends with 140.dll (i.e.
searching for *150.dll doesn't return anything).

The problem is probably that this "_VersionNumber" function is only used to
retrieve the PGO runtime library (pgort140.dll), the other runtime
dependencies are don't use it, see
https://cs.chromium.org/chromium/src/build/vs_toolchain.py?l=236&rcl=37704861...

I'll try to clean this up.

On Wed, May 10, 2017 at 5:32 PM, <brucedawson@chromium.org> wrote:

>
> https://codereview.chromium.org/2653473002/diff/20001/
> build/vs_toolchain.py
> File build/vs_toolchain.py (right):
>
> https://codereview.chromium.org/2653473002/diff/20001/
> build/vs_toolchain.py#newcode177
> build/vs_toolchain.py:177: return '150'
> On 2017/05/10 21:23:49, Sébastien Marchand wrote:
> > Is it true? The files in 4e8a360587a3c8ff3fa46aa9271e982bf3e948ec
> seems to be
> > using the 140 version number, any idea why?
>
> I think VS 2017 uses 140, 141, and 150, depending on context. What
> specific files are you referring to?
>
> https://codereview.chromium.org/2653473002/
>



-- 
Sébastien Marchand | Software Developer | sebmarchand@google.com

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.