Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2653463003:
Fix assertion hit on debug build for EventHandlerRegistry (Closed)
DescriptionFix assertion hit on debug build for EventHandlerRegistry
The assertion checks consistency during removing the event handlers
for all the handler classes one by one, and reports inconsistency
because the handlers are partially removed. Such inconsistency can
happen while moving a node from detached document to a main document,
found by clusterfuzz et al.
This changes the consistency check to see only modified handler class.
R=skyostil@chromium.org
BUG=683071, 677596
Review-Url: https://codereview.chromium.org/2653463003
Cr-Commit-Position: refs/heads/master@{#445944}
Committed: https://chromium.googlesource.com/chromium/src/+/c4d67ffc673ac4dc72dc2f7f7bb4d4b1735d229d
Patch Set 1 #Patch Set 2 : Fix a typo. #
Messages
Total messages: 25 (17 generated)
The CQ bit was checked by kochi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Fix assertion hit on debug build for EventHandlerRegistry TODO: This is a tentative fix. BUG=683071, 677596 ========== to ========== Fix assertion hit on debug build for EventHandlerRegistry TODO: This is a tentative fix. BUG=683071, 677596 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
The CQ bit was checked by kochi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
skyostil@chromium.org changed reviewers: + skyostil@chromium.org
lgtm, thanks!
On 2017/01/24 14:47:20, Sami wrote: > lgtm, thanks! Thanks for the review! I'll change the subject and land this CL.
The CQ bit was checked by kochi@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
Description was changed from ========== Fix assertion hit on debug build for EventHandlerRegistry TODO: This is a tentative fix. BUG=683071, 677596 ========== to ========== Fix assertion hit on debug build for EventHandlerRegistry The assertion checks consistency during removing the event handlers for all the handler classes one by one, and reports inconsistency because the handlers are partially removed. Such inconsistency can happen while moving a node from detached document to a main document, found by clusterfuzz et al. This changes the consistency check to see only modified handler class. R=skyostil@chromium.org BUG=683071, 677596 ==========
kochi@chromium.org changed reviewers: + dcheng@chromium.org
dcheng@, could you review as an OWNER?
lgtm
The CQ bit was checked by kochi@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485308321891920,
"parent_rev": "e1c22801b062c8638e1640290fdcf08923b380a9", "commit_rev":
"c4d67ffc673ac4dc72dc2f7f7bb4d4b1735d229d"}
Message was sent while issue was closed.
Description was changed from ========== Fix assertion hit on debug build for EventHandlerRegistry The assertion checks consistency during removing the event handlers for all the handler classes one by one, and reports inconsistency because the handlers are partially removed. Such inconsistency can happen while moving a node from detached document to a main document, found by clusterfuzz et al. This changes the consistency check to see only modified handler class. R=skyostil@chromium.org BUG=683071, 677596 ========== to ========== Fix assertion hit on debug build for EventHandlerRegistry The assertion checks consistency during removing the event handlers for all the handler classes one by one, and reports inconsistency because the handlers are partially removed. Such inconsistency can happen while moving a node from detached document to a main document, found by clusterfuzz et al. This changes the consistency check to see only modified handler class. R=skyostil@chromium.org BUG=683071, 677596 Review-Url: https://codereview.chromium.org/2653463003 Cr-Commit-Position: refs/heads/master@{#445944} Committed: https://chromium.googlesource.com/chromium/src/+/c4d67ffc673ac4dc72dc2f7f7bb4... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/c4d67ffc673ac4dc72dc2f7f7bb4... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
