Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 2653273005: Bluetooth: macOS: Spelling consistency (Closed)

Created:
3 years, 11 months ago by jlebel
Modified:
3 years, 10 months ago
Reviewers:
scheib
CC:
chromium-reviews, scheib+watch_chromium.org, ortuno+watch_chromium.org, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Bluetooth: macOS: Spelling consistency Changing PendingNotifyCallback to PendingNotifyCallbacks types, and from subscribe_to_notification_callback_ to subscribe_to_notification_callbacks_ in BluetoothRemoteGattCharacteristicMac. BUG= Review-Url: https://codereview.chromium.org/2653273005 Cr-Commit-Position: refs/heads/master@{#446637} Committed: https://chromium.googlesource.com/chromium/src/+/d3b4b8f154a44b6e7d280e7c641a9768dc5a12c6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M device/bluetooth/bluetooth_remote_gatt_characteristic_mac.h View 1 chunk +3 lines, -3 lines 0 comments Download
M device/bluetooth/bluetooth_remote_gatt_characteristic_mac.mm View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
jlebel
Hello Vincent, Can you review this small patch about spelling consistency? Thanks
3 years, 11 months ago (2017-01-26 17:46:52 UTC) #2
scheib
lgtm
3 years, 11 months ago (2017-01-26 22:13:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2653273005/1
3 years, 11 months ago (2017-01-26 22:14:11 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/377095)
3 years, 11 months ago (2017-01-27 00:15:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2653273005/1
3 years, 10 months ago (2017-01-27 09:54:57 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-01-27 10:46:21 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d3b4b8f154a44b6e7d280e7c641a...

Powered by Google App Engine
This is Rietveld 408576698